Added missing static IDs

Added Subscriber.ts which is passed to ActionBus instead of functions.

actions/ActionBus.ts

@@ -1,4 +1,5 @@
 import Action from "./Action";
+import Subscriber from "./Subscriber";
 
 /**
  * The ActionBus is the bus to allow different elements of your program to be notified when a new Action is published,
@@ -7,51 +8,47 @@ import Action from "./Action";
 class ActionBus {
 
     /**
-     * The subscribed functions. Map of Action IDs to all the subscribed Functions for that Action ID.
+     * The subscribed Subscribers. Map of Action IDs to all the Subscribers for that Action ID.
      */
-    private subscribers : Record<number, Function[]> = {}
+    private subscribers : Record<number, Subscriber[]> = {}
 
     /**
-     * Subscribe to listen for new Actions of a certain type to come in, at which point the passed function
-     * will be called. The same Function can be subscribed multiple times.
+     * Subscribe to listen for new Actions of a certain type to come in, at which point the passed Subscriber
+     * will be notified. The same Subscriber can be subscribed multiple times.
      * @param action {typeof Action|number} The Action type to listen for. Can be an Action class, or an Action ID.
-     * @param fn {Function} The function to be called when the Action is received. Should be non-null. Should take at
-     * least one argument, which is the Action. Further arbitrary "rest" arguments can be passed to {@link publish},
-     * which can be received by this function.
+     * @param sub {Subscriber} The Subscriber to be notified when the specified Action is published.
      * @returns {boolean} True if the subscriber is added successfully, false otherwise.
      */
-    public subscribe(action: typeof Action|number, fn: Function) : boolean {
-        if(action == null || fn == null) {
+    public subscribe(action: typeof Action|number, sub: Subscriber) : boolean {
+        if(action == null || sub == null) {
             return false
         }
         const actionId = typeof action == "number" ? action : action.id
         if(this.subscribers[actionId] == null) {
             this.subscribers[actionId] = []
         }
-        this.subscribers[actionId].push(fn)
+        this.subscribers[actionId].push(sub)
         return true
     }
 
     /**
-     * Unsubscribe to stop listening for a type of Action on a specific Function. Will only unsubscribe the Function
-     * once, so if the passed Function was subscribed multiple times, you will need to unsubscribe multiple times.
+     * Unsubscribe to stop listening for a type of Action on a specific Subscriber. Will only unsubscribe the Subscriber
+     * once, so if the passed Subscriber was subscribed multiple times, you will need to unsubscribe multiple times.
      * @param action {typeof Action|number} The Action type to listen for. Can be an Action class, or an Action ID.
-     * @param fn {Function} The function to be called when the Action is received. Should be non-null. Should take at
-     * least one argument, which is the Action. Further arbitrary "rest" arguments can be passed to {@link publish},
-     * which can be received by this function.
+     * @param sub {Subscriber} The Subscriber to be notified when the specified Action is published.
      * @returns {boolean} True if the subscriber is added successfully, false otherwise. Returns true if the
      * passed Function was never subscribed to the passed Action in the first place.
      */
-    public unsubscribe(action: typeof Action|number, fn: Function) : boolean {
-        if(action == null || fn == null) {
+    public unsubscribe(action: typeof Action|number, sub: Subscriber) : boolean {
+        if(action == null || sub == null) {
             return true
         }
 
         const actionId = typeof action == "number" ? action : action.id
         if(this.subscribers[actionId] == null) {
             return true
         }
-        const index = this.subscribers[actionId].indexOf(fn)
+        const index = this.subscribers[actionId].indexOf(sub)
         if(index < 0 || index >= this.subscribers[actionId].length) {
             return true
         }
@@ -61,16 +58,16 @@ class ActionBus {
     }
 
     /**
-     * Publish a new Action to this ActionBus, notifying all Functions subscribed to the type of Action published.
+     * Publish a new Action to this ActionBus, notifying all Subscribers subscribed to the type of Action published.
      * @param action {Action} The action to publish. Should be non-null.
-     * @param args {Object[]} Arbitrary arguments to pass to the subscriber
+     * @param args {Object[]} Arbitrary arguments to pass to the subscriber.
      */
-    public publish(action: Action, ... args: Object[]) : void {
+    public async publish(action: Action, ... args: Object[]) : Promise<void> {
         if(action == null || this.subscribers[action.id] == null) {
             return
         }
         for(let i = 0; i < this.subscribers[action.id].length; i++) {
-            this.subscribers[action.id][i](action, ...args)
+            await this.subscribers[action.id][i].run(action, ...args)
         }
     }
 }

actions/Subscriber.ts

@@ -0,0 +1,16 @@
+import Action from "./Action";
+
+/**
+ * Subscribers can be subscribed to the ActionBus to be notified when a specific Action is published to the bus.
+ */
+abstract class Subscriber {
+    /**
+     * Run function called when the ActionBus this Subscriber is called to notifies this Subscriber of a new Action.
+     * @param action {Action} The Action that caused this Subscriber to be notified.
+     * @param args {Object[]} Arbitrary arguments provided by the ActionBus publisher.
+     */
+    abstract async run(action: Action, ... args: Object[]): Promise<void>
+}
+
+export default Subscriber
+

actions/clientbound/AuthBeginHandshakeAction.ts

@@ -10,6 +10,8 @@ import {Buffer} from 'buffer'
  */
 class AuthBeginHandshakeAction extends Action {
 
+    static id = 26
+
     /**
 	 * Create a new AuthBeginHandshakeAction.
 	 * @param handshakeToken {string} Handshake token to send

actions/clientbound/AuthCompleteAction.ts

@@ -11,6 +11,8 @@ import {Buffer} from 'buffer'
  */
 class AuthCompleteAction extends Action {
 
+    static id = 28
+
     /**
      * Create a new AuthCompleteAction.
      * @param sessionToken {string} Session token to send

actions/clientbound/DisableModAction.ts

@@ -10,6 +10,8 @@ import {Buffer} from 'buffer'
  */
 class DisableModAction extends Action {
 
+    static id = 2
+
     /**
 	 * Create a new DisableModAction.
      * @param reason {string} The reason the mod was disabled

actions/clientbound/EnableModAction.ts

@@ -6,6 +6,8 @@ import Action from '../Action'
  */
 class EnableModAction extends Action {
 
+    static id = 1
+
     /**
 	 * Create a new EnableModAction.
 	 */

actions/clientbound/OpenGuiAction.ts

@@ -11,6 +11,8 @@ import {Buffer} from 'buffer'
  */
 class OpenGuiAction extends Action {
 
+    static id = 10
+
     /**
      * Create a new OpenGuiAction.
      * @param classpath {string} The path of the class to open as a GUI.

actions/clientbound/OpenScreenAction.ts

@@ -10,6 +10,8 @@ import {Buffer} from 'buffer'
  */
 class OpenScreenAction extends Action {
 
+    static id = 11
+
     /**
 	 * Create a new OpenScreenAction.
 	 * @param screenName {string} The name of the screen that the client should open.

actions/clientbound/RefreshCacheAction.ts

@@ -8,6 +8,8 @@ import Action from '../Action'
  */
 class RefreshCacheAction extends Action {
 
+    static id = 12
+
     /**
 	 * Create a new RefreshCacheAction.
 	 */

actions/clientbound/ResetConfigAction.ts

@@ -6,6 +6,8 @@ import Action from '../Action'
  */
 class ResetConfigAction extends Action {
 
+    static id = 5
+
     /**
 	 * Create a new ResetConfigAction.
 	 */

actions/clientbound/SendChatCommandAction.ts

@@ -10,6 +10,8 @@ import {Buffer} from 'buffer'
  */
 class SendChatCommandAction extends Action {
 
+    static id = 6
+
     /**
 	 * Create a new SendChatCommandAction.
 	 * @param cmd {string} Command to send. Beginning slash will automatically be removed if provided,

actions/clientbound/SendChatComponentAction.ts

@@ -11,6 +11,8 @@ import {Buffer} from 'buffer'
  */
 class SendChatComponentAction extends Action {
 
+    static id = 3
+
     /**
 	 * Create a new SendChatComponentAction.
 	 * @param component {Message} Chat component message for the client to send

actions/clientbound/SetAliasedActionAction.ts

@@ -13,6 +13,8 @@ import {Buffer} from 'buffer'
  */
 class SetAliasedActionAction extends Action {
 
+    static id = 7
+
     /**
      * Create a new SetAliasedActionAction.
      * @param aliasedAction {AliasedAction} Aliased action to be saved to the client.

actions/clientbound/SetButtonAction.ts

@@ -15,6 +15,8 @@ import {Buffer} from 'buffer'
  */
 class SetButtonAction extends Action {
 
+    static id = 8
+
     /**
      * Create a new SetButtonAction.
      * @param button {Button} Button to be saved to the client.

actions/clientbound/SetCurrentServerAction.ts

@@ -15,6 +15,8 @@ import {Buffer} from 'buffer'
  */
 class SetCurrentServerAction extends Action {
 
+    static id = 13
+
     /**
 	 * Create a new SetCurrentServerAction.
 	 * @param serverName {string} The name of the server that the client has connected to.

actions/clientbound/SetGlyphForUserAction.ts

@@ -14,6 +14,8 @@ import {Buffer} from 'buffer'
  */
 class SetGlyphForUserAction extends Action {
 
+    static id = 14
+
     /**
      * Create a new SetGlyphForUserAction.
      * @param uuid {string} The UUID of the user for which this Glyph belongs.

actions/clientbound/SetKeybindsAction.ts

@@ -12,6 +12,8 @@ import {Buffer} from 'buffer'
  */
 class SetKeybindsAction extends Action {
 
+    static id = 15
+
     /**
 	 * Create a new SetKeybindsAction.
 	 * @param keybinds {Record<string, ?>[]} New keybinds to serialize and send to the client.

actions/clientbound/SetPremiumAboutAction.ts

@@ -11,6 +11,8 @@ import {Buffer} from 'buffer'
  */
 class SetPremiumAboutAction extends Action {
 
+    static id = 16
+
     /**
 	 * Create a new SetPremiumAboutAction.
 	 * @param component {ChatComponent} Chat component to set the about text to.

actions/clientbound/SetScreenAction.ts

@@ -17,6 +17,8 @@ import {Buffer} from 'buffer'
  */
 class SetScreenAction extends Action {
 
+    static id = 9
+
     /**
      * Create a new SetScreenAction.
      * @param screen {Screen} Screen to be saved to the client.

actions/clientbound/SetTranslationAction.ts

@@ -12,6 +12,8 @@ import {Buffer} from 'buffer'
  */
 class SetTranslationAction extends Action {
 
+    static id = 17
+
     /**
 	 * Create a new SetTranslationAction.
      * @param key {string} The key of the translation to set.

actions/clientbound/SystemOutAction.ts

@@ -7,6 +7,8 @@ import {Buffer} from 'buffer'
  */
 class SystemOutAction extends Action {
 
+    static id = 4
+
     /**
 	 * Create a new SystemOutAction.
 	 * @param message {string} the message to send to the client's logs

actions/serverbound/AuthEndHandshakeAction.ts

@@ -2,7 +2,6 @@ import Action from '../Action'
 import {Buffer} from 'buffer'
 
 /**
- * SERVERBOUND - Server should not instantiate.
  * ID: 27
  * Received by the server when the client is done authenticating with
  * Mojang's servers, and Quickplay's backend should check for authenticity.
@@ -12,6 +11,7 @@ import {Buffer} from 'buffer'
  */
 class AuthEndHandshakeAction extends Action {
 
+    static id = 27
     /**
 	 * Create a new AuthEndHandshakeAction.
      * @param username {string} The current client's username

actions/serverbound/ButtonPressedAction.ts

@@ -2,7 +2,6 @@ import Action from '../Action'
 import {Buffer} from 'buffer'
 
 /**
- * SERVERBOUND - Server should not instantiate.
  * ID: 18
  * Received by the server when the client has pressed a Quickplay button, or a keybind which points to a button.
  *
@@ -11,6 +10,8 @@ import {Buffer} from 'buffer'
  */
 class ButtonPressedAction extends Action {
 
+    static id = 18
+
     /**
 	 * Create a new ButtonPressedAction.
 	 * @param buttonKey {string} The key of the button which was pressed

actions/serverbound/ExceptionThrownAction.ts

@@ -2,7 +2,6 @@ import Action from '../Action'
 import {Buffer} from 'buffer'
 
 /**
- * SERVERBOUND - Server should not instantiate.
  * ID: 19
  * Received by the server when an exception is reported by the client.
  *
@@ -27,6 +26,8 @@ import {Buffer} from 'buffer'
  */
 class ExceptionThrownAction extends Action {
 
+    static id = 19
+
     /**
      * Create a new ExceptionThrownAction.
      * @param type {string} The type of this exception.

actions/serverbound/HypixelLocationChangedAction.ts

@@ -2,7 +2,6 @@ import Action from '../Action'
 import {Buffer} from 'buffer'
 
 /**
- * SERVERBOUND - Server should not instantiate.
  * ID: 20
  * Received by the server when the client changes locations on Hypixel.
  *
@@ -11,6 +10,8 @@ import {Buffer} from 'buffer'
  */
 class HypixelLocationChangedAction extends Action {
 
+    static id = 20
+
     /**
 	 * Create a new HypixelLocationChangedAction.
 	 * @param locationJson {string} JSON about this player's location.

actions/serverbound/InitializeClientAction.ts

@@ -2,7 +2,6 @@ import Action from '../Action'
 import {Buffer} from 'buffer'
 
 /**
- * SERVERBOUND - Server should not instantiate.
  * ID: 25
  * Received by the server when the client first initializes the socket. Intended to send client metadata.
  *
@@ -34,6 +33,8 @@ import {Buffer} from 'buffer'
  */
 class InitializeClientAction extends Action {
 
+    static id = 25
+
     /**
      * Create a new InitializeClientAction.
      */

actions/serverbound/LanguageChangedAction.ts

@@ -2,7 +2,6 @@ import Action from '../Action'
 import {Buffer} from 'buffer'
 
 /**
- * SERVERBOUND - Server should not instantiate.
  * ID: 22
  * Received by the server when the client changes languages.
  *
@@ -11,6 +10,8 @@ import {Buffer} from 'buffer'
  */
 class LanguageChangedAction extends Action {
 
+    static id = 22
+
     /**
 	 * Create a new LanguageChangedAction.
 	 * @param langId {string} New language ID

actions/serverbound/MigrateKeybindsAction.ts

@@ -2,7 +2,6 @@ import Action from '../Action'
 import {Buffer} from 'buffer'
 
 /**
- * SERVERBOUND - Server should not instantiate.
  * ID: 21
  * Send the list keybinds to the server so the server can respond with a migrated keybinds list.
  * This is currently only used to migrate keybinds from pre-2.1.0 to post-2.1.0.
@@ -13,6 +12,8 @@ import {Buffer} from 'buffer'
  */
 class MigrateKeybindsAction extends Action {
 
+    static id = 21
+
     /**
      * Create a new MigrateKeybindsAction.
      * @param keybinds {Record<string, ?>[]} New keybinds to serialize and send to the server.