Update to fabric loom 1.8 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnnuiL
suggested changes
Oct 13, 2024
Comment on lines
+162
to
163
| - project.getLogger().info("fabric-installer.json not found in dependencies"); | ||
| + project.getLogger().warn("installer json not found in dependencies!"); |
There was a problem hiding this comment.
Suggested change
| - project.getLogger().info("fabric-installer.json not found in dependencies"); | |
| + project.getLogger().warn("installer json not found in dependencies!"); | |
| - project.getLogger().info("fabric-installer.json not found in dependencies"); | |
| + project.getLogger().info("installer json not found in dependencies!"); |
TheGlitch76
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
While this looks good in the diff, I'm going to merge this as-is without releasing and then manually examine the codebase and make sure everything looks OK (specifically Support QMJ, which sometimes needs new patches to support new Loom features) and release in a few hours.
Thanks for your help!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.