fix generateDiff task when target version doesn't exist
#671
+79
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersaiyansubtlety
added
bug
supersaiyansubtlety
added
the
update-base
|
🚀 Target branch has been updated to 1.21.4 |
github-actions
bot
removed
the
update-base
make diffTarget a TargetVersionConsumingTask
supersaiyansubtlety
force-pushed
the
fix-generate-diff-task
branch
from
dfee3c2 to
4890c3f
Compare
…kVersionsMatchConsumingTask as they depend on other UnpickVersionsMatchConsumingTasks give lazilyDiffTarget a custom type that implements UnpickVersionsMatchConsumingTask make lazilyDiffTarget's conditional dependency use a provider to make it lazier use try-with-resources when writing the output in DiffDirectoriesTask
ix0rai
added
the
update-base
|
🚀 Target branch has been updated to 25w02a |
github-actions
bot
added
v: snapshot
IotaBread
approved these changes
Jan 18, 2025
supersaiyansubtlety
added
final-comment-period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this only affects the diff task, which is not currently used in the
generate-diffaction (which works fine since #670).generateDiff->diffTargetdiffTargetaTargetVersionConsumingTaskso it gets skipped if the target version doesn't existlazilyDiffTargetas a hack to prevent unnecessarily generating sources using local mappings when the target version isn't present