Initial feature flags API #274
Conversation
| @Unique | ||
| private final BitSet quilt$additionalFlags = new BitSet(); | ||
|
|
||
| @Inject(method = "isIn", at = @At(value = "RETURN", ordinal = 2), cancellable = true) |
There was a problem hiding this comment.
I'd rather see use of @Slice over ordinals. Ordinals are super fragile (what if the method adds an early return at the head?) and if this code ever breaks, it's not going to be clear to me (or whoever else takes up the responsibility of porting) what you were targeting. Feel free to ping me if you need help.
There was a problem hiding this comment.
In this case, ordinal is fairly safe because the function is 6 lines, an if-else chain with two early returns, then a simple bit mask check. If a slice is still recommended I can put one in, but this is one of the few cases where I think including a slice is unnecessary or possibly even more confusing.
There was a problem hiding this comment.
If possible, I'd like enough description of some kind (either a few words in a comment or a slice) that gives me enough of an idea that I could fix the ordinals on this mixin in an update without needing to open up an old QSL workspace and reverse-engineer the injection points myself.
| * Provides helper methods for working with {@link FeatureFlag}s. | ||
| */ | ||
| @ApiStatus.NonExtendable | ||
| public interface QuiltFeatureFlags { |
There was a problem hiding this comment.
This should be a (final) class for consistency.
ix0rai
added
new: module
An API to make use of the new
FeatureFlagssystem.Originally limited to 64 flags, this API extends the size of feature flags using a
BitSet, which grows as needed.Additionally, the
GatedFeature#FILTERED_REGISTRIESset is made mutable to allow for new registries to be added.