handle the emit in try/catch #47

GMetaxakis · 2017-12-20T19:21:20Z

issue #46

GMetaxakis · 2017-12-20T19:55:52Z

may I know when the next version will go live?

mattqs · 2017-12-20T20:03:11Z

First week in 2018.

re-cheid · 2018-02-21T17:56:00Z

Src/EngineIoClientDotNet.mono/Client/Socket.cs

@@ -445,7 +445,7 @@ private bool Flush()
            var log = LogManager.GetLogger(Global.CallerName());

            log.Info(string.Format("ReadyState={0} Transport.Writeable={1} Upgrading={2} WriteBuffer.Count={3}",ReadyState,Transport.Writable,Upgrading, WriteBuffer.Count));
-            if (ReadyState != ReadyStateEnum.CLOSED && this.Transport.Writable && !Upgrading && WriteBuffer.Count != 0)
+            if (ReadyState != ReadyStateEnum.CLOSED && ReadyState == ReadyStateEnum.OPEN && this.Transport.Writable && !Upgrading && WriteBuffer.Count != 0)


this can be shortened:
if ReadyState == ReadyStateEnum.OPEN has to be true ReadyState != ReadyStateEnum.CLOSED is always true, the first condition is not needed

handle in try/catch the emit

5edd066

mattqs approved these changes Dec 20, 2017

View reviewed changes

fix issue #49

2a954c9

mattqs merged commit 13fc371 into Quobject:master Dec 20, 2017

re-cheid reviewed Feb 21, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

handle the emit in try/catch #47

handle the emit in try/catch #47

GMetaxakis commented Dec 20, 2017 •

edited

Loading

GMetaxakis commented Dec 20, 2017

mattqs commented Dec 20, 2017

re-cheid Feb 21, 2018

handle the emit in try/catch #47

handle the emit in try/catch #47

Conversation

GMetaxakis commented Dec 20, 2017 • edited Loading

GMetaxakis commented Dec 20, 2017

mattqs commented Dec 20, 2017

re-cheid Feb 21, 2018

Choose a reason for hiding this comment

GMetaxakis commented Dec 20, 2017 •

edited

Loading