Merge pull request #6951 from JerryWu1234/6950_fix_demo

fix: a bug that error in the middleware occurs 404

.changeset/gorgeous-garlics-melt.md

@@ -0,0 +1,5 @@
+---
+'@builder.io/qwik': patch
+---
+
+fix a bug that error in the middleware occurs 404

packages/docs/src/routes/demo/qwikcity/middleware/layout.tsx

@@ -3,13 +3,14 @@ import { type RequestHandler } from '@builder.io/qwik-city';
 export const onRequest: RequestHandler = async ({ next }) => {
   try {
     await next();
-  } catch (error) {
-    if (
+  } catch (error: any) {
+    if (error?.message === 'ERROR: Demonstration of an error response.') {
+      return await next();
+    } else if (
       error &&
       typeof error === 'object' &&
       'message' in error &&
-      typeof error.message === 'string' &&
-      error.message == 'ERROR: Demonstration of an error response.'
+      typeof error.message === 'string'
     ) {
       // ignore this error
       return;

starters/apps/qwikcity-test/src/routes/(common)/[...catchall]/index.tsx

@@ -28,7 +28,15 @@ export const head: DocumentHead = () => {
   };
 };
 
-export const onGet: RequestHandler = ({ url, exit: exitMiddlewares }) => {
+export const onGet: RequestHandler = ({
+  error,
+  url,
+  exit: exitMiddlewares,
+}) => {
+  if (url.pathname === "/qwikcity-test/catchall-error/") {
+    throw error(500, "ERROR: Demonstration of an error response.");
+  }
+
   if (url.pathname === "/qwikcity-test/catchall/") {
     // special case catchall
     return;

starters/e2e/qwikcity/catchall.spec.ts

@@ -28,4 +28,11 @@ function tests() {
     const status = response.status();
     expect(status).toBe(404);
   });
+
+  test("Error Catchall", async ({ context }) => {
+    const page = await context.newPage();
+    const response = (await page.goto("/qwikcity-test/catchall-error/"))!;
+    const status = response.status();
+    expect(status).toBe(500);
+  });
 }