Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade authcore level #6147

Merged
merged 8 commits into from
May 6, 2024
Merged

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Apr 23, 2024

Overview

Fixes #6122

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 changed the title upgrade authcore level fix: upgrade authcore level Apr 23, 2024
@wmertens
Copy link
Member

@Nefcanto anything to add here? There's no test for this. I can generate a build so you can test.

@JerryWu1234 JerryWu1234 marked this pull request as ready for review April 26, 2024 11:53
@PatrickJS
Copy link
Member

build failed

@Nefcanto
Copy link

Nefcanto commented May 1, 2024

@wmertens, I have nothing to add. I don't know the internals of @auth/core.

@PatrickJS
Copy link
Member

@JerryWu1234 is there anything I can do to help with this PR? I need the latest version of auth now for my project 😅

@JerryWu1234
Copy link
Contributor Author

@JerryWu1234 is there anything I can do to help with this PR? I need the latest version of auth now for my project 😅

I'm going to fix it this weekend because I’m on vacation.

Does This time match your time?

@JerryWu1234
Copy link
Contributor Author

image
I fixed it

@JerryWu1234
Copy link
Contributor Author

image

@PatrickJS I have followed this step, but still was the wrong - =
maybe your help

@JerryWu1234
Copy link
Contributor Author

@PatrickJS now is fine

@PatrickJS PatrickJS merged commit d4f1043 into QwikDev:main May 6, 2024
21 checks passed
@Nefcanto
Copy link

Not solved yet.

@PatrickJS
Copy link
Member

the qwik/auth package wasn't updated

@Nefcanto
Copy link

@PatrickJS, OK thanks. So we should wait for the qwik/auth to be updated and then update the @auth/core. Got it.

@seanperez-xyz
Copy link

seanperez-xyz commented May 21, 2024

erm... I went in manually and changed the version of qwik-auth that didnt help

"devDependencies": {
    "@auth/core": "^0.30.0",
    "@builder.io/qwik": "^1.5.4",
    "@builder.io/qwik-auth": "0.1.3",
    "@builder.io/qwik-city": "^1.5.4",

should we change the '@builder.io' to QwikDev or something ?

this works

"@auth/core": "^0.13.0",
"@builder.io/qwik": "^1.5.4",
"@builder.io/qwik-auth": "0.1.3",

@Nefcanto
Copy link

@PatrickJS, after updating the @builder.io/qwik-auth to ^0.2.1, and @auth/core to 0.31.0, we still get the same error:

[auth][error] UnknownAction: Cannot parse action at /api/auth/session. Read more at https://errors.authjs.dev#unknownaction
    at parseActionAndProviderId (file:///npm/node_modules/@auth/core/lib/utils/web.js:92:15)
    at toInternalRequest (file:///npm/node_modules/@auth/core/lib/utils/web.js:24:40)
    at Module.Auth (file:///npm/node_modules/@auth/core/index.js:67:35)
    at getSessionData (/npm/node_modules/@builder.io/qwik-auth/lib/index.qwik.mjs:311:50)
    at onRequest (/npm/node_modules/@builder.io/qwik-auth/lib/index.qwik.mjs:247:50)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Object.next (file:///npm/node_modules/@builder.io/qwik-city/vite/index.mjs:25269:9)
    at async runNext (file:///npm/node_modules/@builder.io/qwik-city/vite/index.mjs:25534:5)
    at async file:///npm/node_modules/@builder.io/qwik-city/vite/index.mjs:26125:26
12:59:31 PM [vite] Internal server error: 
      at getSessionData (/npm/node_modules/@builder.io/qwik-auth/lib/index.qwik.mjs:328:9)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async onRequest (/npm/node_modules/@builder.io/qwik-auth/lib/index.qwik.mjs:244:34)
      at async Object.next (file:///npm/node_modules/@builder.io/qwik-city/vite/index.mjs:25269:9)
      at async runNext (file:///npm/node_modules/@builder.io/qwik-city/vite/index.mjs:25534:5)
      at async file:///npm/node_modules/@builder.io/qwik-city/vite/index.mjs:26125:26

@gioboa
Copy link
Member

gioboa commented May 30, 2024

Hi, I'm working on a new Qwik integration in collaboration with the Auth.js team. The current integration is no longer compatible with the new Auth.js APIs I guess.

@Nefcanto
Copy link

Nefcanto commented Jun 1, 2024

@gioboa, thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[✨] Please upgrade @auth/core version in qwik-auth
6 participants