feat(v2): SSRBlock and SSRStream implementation #6181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhevery
requested changes
Apr 30, 2024
| @@ -421,6 +421,10 @@ class SSRContainer extends _SharedContainer implements ISSRContainer { | |||
| this.write(rawHtml); | |||
| } | |||
|
|
|||
| commentNode(text: string) { | |||
| this.write('<!--' + text + '-->'); | |||
There was a problem hiding this comment.
I think these comment nodes will confuse the current implementation of materializeFromVNodeData, so we will need to update that.
There was a problem hiding this comment.
It is already done by this code :D but I have added additional test for this
while (!isElement(child)) {
child = child!.nextSibling;
if (!child) {
throwErrorAndStop(
'Materialize error: missing element: ' + vData + ' ' + peek() + ' ' + nextToConsumeIdx
);
}
}
mhevery
approved these changes
May 3, 2024
This was referenced Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
SSRBlockandSSRStreamcomponents