fix(v2): component rerender with the same key and different props #6208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Varixo
changed the title
Varixo
commented
May 2, 2024
| @@ -1046,8 +1046,8 @@ function propsDiffer(src: Record<string, any>, dst: Record<string, any>): boolea | |||
| if (!src || !dst) { | |||
| return true; | |||
| } | |||
| let srcKeys = removeChildrenKey(Object.keys(src)); | |||
There was a problem hiding this comment.
in props we don't have children anymore, so I assume this is not needed now. Let me know if I am wrong
There was a problem hiding this comment.
Right, the optimizer makes sure combined with _jsxC which checks at runtime.
However, the children prop can still be in the varProps, it should just be ignored
mhevery
approved these changes
May 3, 2024
This was referenced Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes component rerender with the same key and different props