Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: inital version of the Brand page #6798

Merged
merged 8 commits into from
Oct 14, 2024
Merged

Conversation

Kampouse
Copy link
Contributor

What is it?

#6195 inital version of the brand page!
image

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

added the brand page and a link in the footer

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@Kampouse Kampouse requested a review from a team as a code owner August 15, 2024 19:56
Copy link

changeset-bot bot commented Aug 15, 2024

⚠️ No Changeset found

Latest commit: e85f88f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 15, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 77c96d8

PatrickJS
PatrickJS previously approved these changes Aug 15, 2024
PatrickJS
PatrickJS previously approved these changes Aug 15, 2024
@Kampouse
Copy link
Contributor Author

removed some local change that should not be here

Copy link
Member

@thejackshelton thejackshelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

If we could remove the multiple h1's, since I think that is an a11y issue

An idea, maybe each logo gets downloaded when clicking on it? Or buttons beside each to download it with png or svg?

As for the color, clicking on each color copies that color. similar to https://tailwindcss.com/docs/customizing-colors

@Kampouse
Copy link
Contributor Author

Kampouse commented Aug 16, 2024

@thejackshelton Wanted to see if was going in the right direction before adding js 😄 !
took good inspiration from the solid: https://www.solidjs.com/media
thanks!

@Kampouse
Copy link
Contributor Author

made all the element clickable
image
and made sur element are visible with acessibity tool

Copy link
Contributor

@maiieul maiieul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start indeed!

Could you add some space between logos section and navbar and footer?

Astro has a nice page for this https://astro.build/press/

Also I prefer /press edit: I prefer /brand 🙈 doesn't matter too much ^^

Also having a "download all" button like Astro would help for the space between logos and footer. Makes it more harmonious and useful too.

Also using Cards to separate each item would make this look awesome. You could use the qwik-ui styled copy/paste Card component for this.

Please don't hesitate to reach out if you encounter any roadblocks.

Thanks for doing this @Kampouse!

@wmertens
Copy link
Member

@Kampouse don't forget about this, it would be a very nice addition :)

apart from the issues Maiieul found, for me the UWU version is squashed on wider views.

@Kampouse
Copy link
Contributor Author

image updated the page to be easier to mess with look into the card components in qwikui added the dowload all and some padding in y axis the uwu look more consistent now ...

@Kampouse
Copy link
Contributor Author

image
let me know if anything to update

@PatrickJS PatrickJS enabled auto-merge (squash) October 14, 2024 23:33
@PatrickJS PatrickJS dismissed stale reviews from maiieul and thejackshelton October 14, 2024 23:34

done

@PatrickJS PatrickJS merged commit 03689b7 into QwikDev:main Oct 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants