-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: inital version of the Brand page #6798
Conversation
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
removed some local change that should not be here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start!
If we could remove the multiple h1's, since I think that is an a11y issue
An idea, maybe each logo gets downloaded when clicking on it? Or buttons beside each to download it with png or svg?
As for the color, clicking on each color copies that color. similar to https://tailwindcss.com/docs/customizing-colors
@thejackshelton Wanted to see if was going in the right direction before adding js 😄 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start indeed!
Could you add some space between logos section and navbar and footer?
Astro has a nice page for this https://astro.build/press/
Also I prefer edit: I prefer /press
/brand
🙈 doesn't matter too much ^^
Also having a "download all" button like Astro would help for the space between logos and footer. Makes it more harmonious and useful too.
Also using Cards to separate each item would make this look awesome. You could use the qwik-ui styled copy/paste Card component for this.
Please don't hesitate to reach out if you encounter any roadblocks.
Thanks for doing this @Kampouse!
@Kampouse don't forget about this, it would be a very nice addition :) apart from the issues Maiieul found, for me the UWU version is squashed on wider views. |
What is it?
#6195 inital version of the brand page!
Description
added the brand page and a link in the footer
Checklist:
pnpm change
and documented my changes