Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(serdes): vnode tree shaking #6963

Merged
merged 22 commits into from
Nov 13, 2024
Merged

perf(serdes): vnode tree shaking #6963

merged 22 commits into from
Nov 13, 2024

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Oct 10, 2024

Only serialize vnodes that are being used.
It's mostly working, tests need updating, but in e.g. the playground has some vnodes it can't find after SSR, so we are missing some ways vnodes are referenced.
It's also serialing all vnode metadata for testing, which is way too much.

Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: c17f585

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wmertens wmertens force-pushed the lazy-vnodes branch 3 times, most recently from 5bb41b3 to 050f444 Compare October 16, 2024 20:14
@wmertens wmertens changed the title perf(serdes): lazy vnodes perf(serdes): vnode tree shaking Oct 25, 2024
@wmertens wmertens marked this pull request as ready for review October 26, 2024 10:35
@wmertens wmertens requested a review from a team as a code owner October 26, 2024 10:35
@wmertens wmertens force-pushed the lazy-vnodes branch 2 times, most recently from 82cd808 to 81adca6 Compare October 29, 2024 11:36
@wmertens wmertens mentioned this pull request Nov 1, 2024
2 tasks
@Varixo Varixo requested review from a team as code owners November 2, 2024 15:49
@Varixo Varixo self-assigned this Nov 9, 2024
Copy link

pkg-pr-new bot commented Nov 13, 2024

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@6963
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@6963
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@6963
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@6963

commit: c17f585

Copy link
Contributor

github-actions bot commented Nov 13, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview c17f585

@wmertens wmertens merged commit fec2039 into build/v2 Nov 13, 2024
19 checks passed
@wmertens wmertens deleted the lazy-vnodes branch November 13, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants