Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server$ not throwing for errors above 500 #7078

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DustinJSilk
Copy link
Contributor

What is it?

  • Bug

Description

Server functions only throw errors in the browser with 500 status code errors.
For errors that are greater than 500, such as a 504, the server functions will return the text which means you are unable to correctly catch and handle the errors.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I added new tests to cover the fix / functionality

@DustinJSilk DustinJSilk requested a review from a team as a code owner November 20, 2024 18:02
Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: abf174f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
@builder.io/qwik Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Nov 20, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7078
npm i https://pkg.pr.new/@builder.io/qwik-city@7078
npm i https://pkg.pr.new/eslint-plugin-qwik@7078
npm i https://pkg.pr.new/create-qwik@7078

commit: abf174f

Copy link
Contributor

github-actions bot commented Nov 20, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview abf174f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant