Improved: update empty-state check, arrange ionic component imports &…

… wrapped ion-button into ion-buttons(hotwax#726)
R-Sourabh · Nov 27, 2024 · 4887cfb · 4887cfb
1 parent 3d5326e
commit 4887cfb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/components/JobConfiguration.vue b/src/components/JobConfiguration.vue
@@ -203,7 +203,7 @@ import emitter from '@/event-bus';
 import { Actions, hasPermission } from '@/authorization'
 import CustomFrequencyModal from '@/components/CustomFrequencyModal.vue';
 import JobParameterModal from '@/components/JobParameterModal.vue'
-import LearnMoreModal from "./LearnMoreModal.vue";
+import LearnMoreModal from "@/components/LearnMoreModal.vue";
 
 export default defineComponent({
   name: "JobConfiguration",

diff --git a/src/components/LearnMoreModal.vue b/src/components/LearnMoreModal.vue
@@ -7,9 +7,11 @@
         </ion-button>
       </ion-buttons>
       <ion-title>{{ translate("Learn more") }}</ion-title>
-      <ion-button slot="end" fill="clear" @click="redirectToJobsDoc()">
-        <ion-icon color="medium" :icon="openOutline" />
-      </ion-button>
+      <ion-buttons slot="end">
+        <ion-button fill="clear" @click="redirectToJobsDoc()">
+          <ion-icon color="medium" :icon="openOutline" />
+        </ion-button>
+      </ion-buttons>
     </ion-toolbar>
   </ion-header>
 
@@ -21,14 +23,14 @@
       </ion-item>
     </div>
 
-    <div class="empty-state" v-else-if="!askResponse">
+    <div class="empty-state" v-else-if="!Object.keys(askResponse).length">
       <ion-item lines="none">
         <p>{{ translate("The job details is not generating, please try again later.") }}</p>
       </ion-item>
     </div>
 
     <div v-else>
-      <ion-item class="ion-margin-top">
+      <ion-item lines="full" class="ion-margin-top">
         <ion-label>
           {{ queryString }}
           <p>{{  currentJob?.systemJobEnumId }}</p>  
@@ -77,8 +79,8 @@ export default defineComponent({
     IonIcon,
     IonItem,
     IonLabel,
-    IonSpinner,
     IonList,
+    IonSpinner,
     IonTitle,
     IonToolbar
   },