Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpak Pilot Model Importing #159

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

SenorGeese
Copy link
Contributor

@SenorGeese SenorGeese commented Mar 15, 2023

I uh, messed up the first one. Here is a new pr. Still needs much cleaning up.

@SenorGeese
Copy link
Contributor Author

@GeckoEidechse if you have the time. Can you re-review this? If you remember any of the issues/problems you had with it.

I remember

  • Set relative link instead of direct link
  • Add screenshots (again)
  • The random quote of a video

@SenorGeese
Copy link
Contributor Author

Just so I don't forget, the main guide was made by Harb.

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a duplicated (mostly) file here, or I'm missing something.

Also, this has very little to do with RPaks, I'd prefer if they were left out of the title. (Titanfall 2 doesn't use RPaks for models but Apex does, I'd prefer to avoid any potential confusion)

I think "Model Modding" would suffice, as the tutorial would work for pretty much any model, just using a pilot model as an example. (similarly to how "RPak Modding" uses a camo RPak as an example in it's tutorial) It would also fit better alongside the other tutorial names.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same as rpakpilotmodding.rst

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An order version, yes.

I didn't know this file existed. I'll clear it up, thanks for pointing it out.

Comment on lines +31 to +34
- `Titanfall VPK Tools`_ - VPK viewer, extractor, and repacker.
"Titanfall VPK Tool" is the vpk tool used. Made by cra0.

- `Crowbar`_ - Decompile, recompile, and a ton of other model and source asset stuff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if a different vpk tool was recommended here, as they are generally considered better these days (Crowbar can do vpk extraction for titanfall 2 properly, so you could just recommend Crowbar for it to avoid having too many required tools)

This change would however require a rewriting/rewording of the section dedicated to extracting the model from the vpk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never recommended a specific vpk tool.

I will take another look in VPK tools to see what is the overall best, but I just continued with cra0's VPKTool because it's popular use in tutorials, it's ability to unpack AND repack.

If I choose Crowbar, I'll rewrite the necessary content.

Comment on lines +175 to +176
Type the file name of the pilot into the search bar to view **texture and material paths**.
View file paths to create paths in RePak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should advise to turn on "Show full asset paths" in Legion+ settings, which I believe is off by default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that but this was just an .rst translation so I kept it "as is". Considering the amount of adjustments and rewriting, I will now add your suggestion.

docs/source/guides/tools/rpakpilotmodding.rst Outdated Show resolved Hide resolved
Comment on lines +241 to +245
Credits:
^^^^^

Base guide from Harb.
Edited by Northstar.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance the base guide could be linked here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

I'll add the original google link, and experiment with the file sharing on the docs.

docs/source/guides/tools/rpakpilotmodding.rst Outdated Show resolved Hide resolved
docs/source/guides/tools/rpakpilotmodding.rst Outdated Show resolved Hide resolved
Comment on lines +64 to +76
The files have different names that correspond to their pilot classes. Below is a clarifying table to help.

==================== =====
VPK .mdl name Name
==================== =====
pilot_light_jester Stim
pilot_light_ged Phase Shift
pilot_medium_stalker Holo Pilot
pilot_medium_reaper Pulse Blade
pilot_medium_geist Grapple
pilot_heavy_roog A-Wall
pilot_heavy_drex Cloak
==================== =====
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably also specify that _f models are the female ones and _m models are the male ones, for completeness and to avoid any potential confusion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add this!

Copy link
Contributor Author

@SenorGeese SenorGeese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answered and responded to Spoon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An order version, yes.

I didn't know this file existed. I'll clear it up, thanks for pointing it out.

Comment on lines +31 to +34
- `Titanfall VPK Tools`_ - VPK viewer, extractor, and repacker.
"Titanfall VPK Tool" is the vpk tool used. Made by cra0.

- `Crowbar`_ - Decompile, recompile, and a ton of other model and source asset stuff
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never recommended a specific vpk tool.

I will take another look in VPK tools to see what is the overall best, but I just continued with cra0's VPKTool because it's popular use in tutorials, it's ability to unpack AND repack.

If I choose Crowbar, I'll rewrite the necessary content.

Comment on lines +64 to +76
The files have different names that correspond to their pilot classes. Below is a clarifying table to help.

==================== =====
VPK .mdl name Name
==================== =====
pilot_light_jester Stim
pilot_light_ged Phase Shift
pilot_medium_stalker Holo Pilot
pilot_medium_reaper Pulse Blade
pilot_medium_geist Grapple
pilot_heavy_roog A-Wall
pilot_heavy_drex Cloak
==================== =====
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add this!

Comment on lines +175 to +176
Type the file name of the pilot into the search bar to view **texture and material paths**.
View file paths to create paths in RePak
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that but this was just an .rst translation so I kept it "as is". Considering the amount of adjustments and rewriting, I will now add your suggestion.

docs/source/guides/tools/rpakpilotmodding.rst Outdated Show resolved Hide resolved
docs/source/guides/tools/rpakpilotmodding.rst Outdated Show resolved Hide resolved
docs/source/guides/tools/rpakpilotmodding.rst Outdated Show resolved Hide resolved
Comment on lines +241 to +245
Credits:
^^^^^

Base guide from Harb.
Edited by Northstar.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

I'll add the original google link, and experiment with the file sharing on the docs.

@github-actions github-actions bot added merge conflicts Blocked by merge conflicts, waiting on the author to resolve and removed merge conflicts Blocked by merge conflicts, waiting on the author to resolve labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants