mods(Safe I/O): Only allow creating files with whitelisted filetypes (#…

…682)

Restricts file types that can be created via Safe I/O to a list of whitelisted file types

primedev/mods/modsavefiles.cpp

@@ -74,6 +74,26 @@ template <ScriptContext context> void SaveFileManager::SaveFileAsync(fs::path fi
 	std::thread writeThread(
 		[mutex, file, contents]()
 		{
+			// Check if has extension and return early if not
+			if (!file.has_extension())
+			{
+				spdlog::error("A mod failed to save a file via Safe I/O due to the following error:");
+				spdlog::error("No file extension specified");
+				return;
+			}
+
+			// If there's a file extension missing here that you need, feel free to make a PR adding it
+			static const std::set<std::string> whitelist = {".txt", ".json"};
+
+			// Check if file extension is whitelisted
+			std::string extension = file.extension().string();
+			if (whitelist.find(extension) == whitelist.end())
+			{
+				spdlog::error("A mod failed to save a file via Safe I/O due to the following error:");
+				spdlog::error("Disallowed file extension: {}", extension);
+				return;
+			}
+
 			try
 			{
 				mutex.get().lock();