Create mod entry in enabledmods.json if it doesn't exist
#410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While loading mods, if there's no related entry in enabledmods.json file, we create one with value=true, activating new mods by default.
|
will this write downloaded mods to the json as well? while we don't have autodownloading yet we do read the mod directory for downloaded mods atm, and i don't think we should ever write downloaded mods to the json |
|
This would be pretty pog ngl |
F1F7Y
added
needs testing
Alystrasz
requested review from
F1F7Y
and removed request for
a team and
BobTheBob9
|
I won't edit the labels for this PR, since I made it, but I'd say this is ready to be merged. :) |
F1F7Y
added
almost ready to merge
Jan200101
previously approved these changes
Jul 4, 2023
GeckoEidechse
dismissed
Jan200101’s stale review
missing comment in approving review
Alystrasz
added
READY TO MERGE
Jan200101
approved these changes
Sep 2, 2023
GeckoEidechse
changed the title
enabledmods.json if it doesn't exist
GeckoEidechse
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you add a new mod to your
mods/directory, when there's no associated entry in theenabledmods.jsonfile, it is considered enabled by default; mod entries are only written inenabledmods.jsonwhen toggling them via the mods interface.In this pull request, I propose to create mod entries in
enabledmods.jsonwhen detecting they don't exist.