Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose origin auth state and errors to squirrel #468

Merged
merged 15 commits into from
Oct 7, 2023
Merged

Expose origin auth state and errors to squirrel #468

merged 15 commits into from
Oct 7, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

Also moves NSIsMasterServerAuthenticated out of scriptserverbrowser.cpp because it didn't really fit there

This will be used for showing failed origin auth errors in the game's UI

@ASpoonPlaysGames ASpoonPlaysGames mentioned this pull request Jun 10, 2023
Merged
2 tasks
pg9182
pg9182 approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@pg9182 pg9182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, not tested.

@F1F7Y F1F7Y added needs testing Changes from the PR still need to be tested almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Jun 28, 2023
F1F7Y
F1F7Y requested changes Jul 9, 2023
View reviewed changes
NorthstarDLL/CMakeLists.txt Outdated Show resolved Hide resolved
F1F7Y
F1F7Y approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Alystrasz
Alystrasz approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR effectively exposes information to the Squirrel VM.
Confirmed working in testing.

@ASpoonPlaysGames ASpoonPlaysGames added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Aug 25, 2023
@NoCatt NoCatt mentioned this pull request Sep 2, 2023
Merged
@GeckoEidechse
Copy link
Member

Merging based on previous reviews. Didn't look at this much myself.

@GeckoEidechse GeckoEidechse merged commit c093ee1 into R2Northstar:main Oct 7, 2023
2 checks passed
@ASpoonPlaysGames ASpoonPlaysGames deleted the origin-auth-dialog branch January 4, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pg9182 pg9182 pg9182 approved these changes

@F1F7Y F1F7Y F1F7Y approved these changes

@Alystrasz Alystrasz Alystrasz approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ASpoonPlaysGames @GeckoEidechse @Alystrasz @F1F7Y @pg9182