-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make clang-format less strict #473
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
ColumnLimit
to 0
also thinking about setting
|
Can we limit this PR to relaxing rules rather than drastically changing formatting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There's some other clang-format settings we should change too, but this is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but will probably cause conflicts in some PRs
Before this gets merged someone should merge main into it, and then fix the formatting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-reviewing since changes were made since my last review.
Still looks good, some additional format changes could be made but its best to split any more changes into new PRs
Quick skim and the changes are an improvement. That being said:
|
For merging this we would first only merge the So basically just revert the actual formatting changes (they are causing merge conflicts rn anyway) so that only the config changes are left and then we can merge this ^^ |
Superseded by #772 |
Docs: https://clang.llvm.org/docs/ClangFormatStyleOptions.html
Makes clang-format less strict and also changes some things to make the code more readable ( this will very obviously require some parts to be changed manually ).
As I took my own spin on formatting and these changes are very individual based i expect this to take time, unlike other PRs.