Fix crash in ReadFileAsync
#521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know when the person from the ticket has tested the version from this PR and we can mark the testing part as complete ^^ |
ASpoonPlaysGames
added
needs testing
ASpoonPlaysGames
approved these changes
Aug 25, 2023
ASpoonPlaysGames
removed
the
needs code review
Jan200101
reviewed
Sep 2, 2023
|
I assume you never got the person from the ticket to test it? I'm kinda unsure how to best test it otherwise? Should we just forego testing an merge without it? |
|
@F1F7Y bump |
github-actions
bot
added
the
merge conflicts
github-actions
bot
removed
the
merge conflicts
|
bump |
|
@F1F7Y sup |
|
As far as I remember only one user had this issue ( this PR fixed it for them ) but they stopped replying. This PR is more of a band aid fix than a long term one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a NULL dereference crash in
ReadFileAsyncThis seems to be very rare, there's currently an open ticket where this occurs. This version hasnt been tested yet.
I also promised to ping
@shmordan_08when this gets releasedCloses #520