Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor debugoverlay.cpp (fix smart pistol lines) #538

Merged
merged 12 commits into from
Oct 30, 2023
Merged

Refactor debugoverlay.cpp (fix smart pistol lines) #538

merged 12 commits into from
Oct 30, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

closes R2Northstar/NorthstarMods#689

This code is probably bad idk dude this is weird stuff. Would be cool to get someone better at cpp than me to review this

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 3, 2023
Alystrasz
Alystrasz reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot approve merging this code since I don't understand it; I can however confirm it seems to be working:

Before

Capture d’écran du 2023-09-18 20-30-57

After

Capture d’écran du 2023-09-18 20-53-12

@ASpoonPlaysGames @F1F7Y
refactor debugoverlay.cpp
071cde5 
Adapted from F1F7Y@51f8d42

Co-Authored-By: F1F7Y <[email protected]>
@ASpoonPlaysGames ASpoonPlaysGames changed the title Fix smart pistol lines not showing Refactor debugoverlay.cpp (fix smart pistol lines) Sep 23, 2023
@ASpoonPlaysGames
Copy link
Contributor Author

Re-requesting testing due to large code changes

Jan200101
Jan200101 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@Jan200101 Jan200101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, re-adds the smart pistol overlay. Did not compare to vanilla.

Did not verify offsets, code looks good, just had 1 thought

NorthstarDLL/client/debugoverlay.cpp Show resolved Hide resolved
@Jan200101 Jan200101 removed the needs testing Changes from the PR still need to be tested label Oct 17, 2023
@ASpoonPlaysGames ASpoonPlaysGames added READY TO MERGE This mergeable right now and removed needs code review Changes from PR still need to be reviewed in code labels Oct 20, 2023
@GeckoEidechse
Copy link
Member

GeckoEidechse commented Oct 30, 2023 •
edited
Loading

Technically missing proper code review but given that code was originally written by @F1F7Y and adapted by @ASpoonPlaysGames I think it should be fine ^^

@GeckoEidechse GeckoEidechse merged commit 6e32a58 into R2Northstar:main Oct 30, 2023
2 checks passed
@ASpoonPlaysGames
Copy link
Contributor Author

Technically missing proper code review but given that code was originally written by @F1F7Y and adapted by @ASpoonPlaysGames I think it should be fine ^^

???
image

@GeckoEidechse
Copy link
Member

:clueless:

@ASpoonPlaysGames ASpoonPlaysGames deleted the smart-pistol-lines branch January 4, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jan200101 Jan200101 Jan200101 approved these changes

@Alystrasz Alystrasz Awaiting requested review from Alystrasz

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smart pistol scan lines dont show up
4 participants
@ASpoonPlaysGames @GeckoEidechse @Alystrasz @Jan200101