-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convar print commands #539
Conversation
Changes: - Rename find to convar_find to keep naming similar to other Convar printing commands - Rename findflags to convar_findByFlags as this command already exists in the engine - Implements convar_list as it already exists in the engine - Implements convar_differences as it already exists in the engine Issues: - convar_list is currently not sorted in alphabetical order - convar_differences will likely need a formatting change
Changes: - Implements alphabetically sorted outputs from concommands - Format the convar_differences output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good!
Works on My Machine |
I tested this and now want to implode (It works) |
works (no crashes for 30 min) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code looks good, I just have a nitpick.
Going to be reworking the code to use |
@H0L0theBard 'sup? |
enforces convars with devonly and hidden flags not being shown by default introduces a bit of code duplication but this is what's in the engine anyway
PR still working for me after 00bab5d |
Tested again and still want to explode (works) |
was able to run all listed commands with proper outputs and no issues 👍 |
(Whoops, missed that code needs re-reviewing since changes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change and a question
I just realised that convar_list (cvarlist in valve source) has the ability to make a list from a search and log to a file.
Probably should implement these eventually. |
- convar_differences not as nested - convar_list prints total amount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, requested changes were addressed :)
Was able to open the console and run all commands with proper outputs with the newest version 👍 |
seems that @GeckoEidechse forgot to add the "ready to merge" label when removing "needs code review" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working fine in quick testing.
Adds various concommands such as
convar_findByFlags
convar_list
convar_differences
convar_find
The first 3 listed above are already registered as concommands natively but didn't seem to do anything when tested.
convar_findByFlags
andconvar_find
were already implemented by Bob under the namesfindflags
andfind
respectively but the names have been changed to reflect already existing convars.All outputs into the console are also alphabetically sorted.