Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for changing command restrictions at runtime #551

Closed
wants to merge 5 commits into from
Closed

Allow for changing command restrictions at runtime #551

wants to merge 5 commits into from

Conversation

ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames commented Sep 15, 2023 •
edited
Loading

This allows for vanilla compat without -norestrictservercommands.

Script is absolutely not set up for this though, so to test:

  1. launch a vanilla profile (without -norestrictservercommands)
  2. go into multiplayer, and matchmake for everyone's favourite mode: Attrition
  3. observe that you cannot connect to a game server, you will stay stuck on the "Connecting to match" bit
  4. set ns_restrict_commands to 0. This will disconnect you from your server and put you back on the main menu.
  5. go back into multiplayer and once again matchmake for everybody's favourite mode.
  6. observe that you can connect and play a match just fine.

EDIT: 0 not 1, brain hurt

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 15, 2023
@ASpoonPlaysGames
Copy link
Contributor Author

bob says convar bad so marking as draft until i rewrite this to be betterer ™️

@ASpoonPlaysGames ASpoonPlaysGames marked this pull request as draft September 15, 2023 20:44
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 20, 2023
@ASpoonPlaysGames ASpoonPlaysGames deleted the vanilla-compat branch January 4, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge conflicts Blocked by merge conflicts, waiting on the author to resolve needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ASpoonPlaysGames