Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce warnings due to calling conventions #555

Merged
merged 4 commits into from
Oct 7, 2023
Merged

Reduce warnings due to calling conventions #555

merged 4 commits into from
Oct 7, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames commented Sep 16, 2023 •
edited by GeckoEidechse
Loading

Removes C4229 "anachronism used: modifiers on data are ignored" warnings

Reduces warning count from 82 to 6

image

Testing:

Literally just play the game for a bit, load some mods, see if you notice any new crashes?

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 16, 2023
Alystrasz
Alystrasz reviewed Sep 17, 2023
View reviewed changes
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the code changes introduced by this PR, but I played a few games (pilots and titans) with no problem.

@ASpoonPlaysGames ASpoonPlaysGames removed the needs testing Changes from the PR still need to be tested label Sep 18, 2023
@GeckoEidechse
Copy link
Member

@ASpoonPlaysGames what would be a good way to test this? Just play the game and hope everything works? ^^"

@ASpoonPlaysGames
Copy link
Contributor Author

@ASpoonPlaysGames what would be a good way to test this? Just play the game and hope everything works? ^^"

Pretty much, yeah

Jan200101
Jan200101 approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@Jan200101 Jan200101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR just removes calling convention from a bunch of places, which is fine.

Does indeed get the build warnings down to 6.

Tested a bit on the Crazy Gungame server and it worked without a problem.

@Jan200101 Jan200101 added READY TO MERGE This mergeable right now and removed needs code review Changes from PR still need to be reviewed in code labels Oct 7, 2023
@GeckoEidechse
Copy link
Member

Merging based on previous reviews.

@GeckoEidechse GeckoEidechse merged commit 0246053 into R2Northstar:main Oct 7, 2023
2 checks passed
@Jan200101 Jan200101 removed the READY TO MERGE This mergeable right now label Oct 7, 2023
@ASpoonPlaysGames ASpoonPlaysGames deleted the compiler-warnings branch January 4, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alystrasz Alystrasz Alystrasz left review comments

@Jan200101 Jan200101 Jan200101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ASpoonPlaysGames @GeckoEidechse @Alystrasz @Jan200101