Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load plugin dependencies from lib folder #590

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Load plugin dependencies from lib folder #590

merged 4 commits into from
Nov 27, 2023

Conversation

RoyalBlue1
Copy link
Contributor

Disables recursive search for plugins in plugin folders and if it exists adds lib folder within plugin folder to Dll load dirs

@RoyalBlue1 RoyalBlue1 changed the title Load plugin dependencies form lib folder within plugin Load plugin dependencies form lib folder Nov 3, 2023
@catornot catornot self-requested a review November 3, 2023 18:47
@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 18, 2023
@GeckoEidechse GeckoEidechse changed the title Load plugin dependencies form lib folder Load plugin dependencies from lib folder Nov 21, 2023
catornot
catornot approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@catornot catornot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well, only destroyed one of my plugins because it was probably unsound before but it wasn't important :)

code looks good

@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 27, 2023
@GeckoEidechse
Copy link
Member

Merging based on review

@GeckoEidechse GeckoEidechse merged commit c427fe4 into R2Northstar:main Nov 27, 2023
2 checks passed
@GeckoEidechse GeckoEidechse mentioned this pull request Dec 21, 2023
Closed
@RoyalBlue1 RoyalBlue1 deleted the pluginDependencyLoading branch January 3, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catornot catornot catornot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RoyalBlue1 @GeckoEidechse @catornot @ASpoonPlaysGames