Disable more compression methods for minizip

[Jan200101]

Doing this because I ran into the following error while compiling with msvc-wine

z:/home/sentry/git/NorthstarLauncher/thirdparty/minizip/mz_strm_zstd.c(17): fatal error C1083: Cannot open include file: 'zstd.h': No such file or directory

What is actually needed from minizip?
This was likely not an issue on windows because of MZ_FETCH_LIBS. Should we turn that off to ensure no extra dependencies get in without our knowledge?

[Alystrasz]

minizip was introduced in #545, and is only used to uncompress archives (no need for compression methods afaik).

I see that some compression features are already disabled in this repository (https://github.com/R2Northstar/NorthstarLauncher/blob/aeecd7a69be8de3afdca124ab624677bfd5582cf/cmake/Findminizip.cmake#L5C61-L5C61), maybe we wanna disable more indeed.

My guess is that MZ_ZLIB is required, but I have to try compiling without it to check.

EDIT: my dumbass thought this was an issue, not a pull request...
I'll check whether mod downloading still works on this.

[Jan200101]

My guess is that MZ_ZLIB is required, but I have to try compiling without it to check.

ZLIB would be required for DEFLATE compressed zips (which is the most common format) but others are also possible.

Considering mod verification is a manual process, should there be some kind of requirement what compression it needs to use?

[Jan200101]

Updated to enable ZLIB for DEFLATE

[Alystrasz]

I confirm disabling those methods does not have any negative impact on mod downloading (tested with #595 branch).

---

Given we agreed on Discord to disable as many flags as possible, I tried disabling more, while ensuring mod downloading still works; I ended up with the following configuration:

if(NOT minizip_FOUND)
	check_init_submodule(${PROJECT_SOURCE_DIR}/thirdparty/minizip)

	set(MZ_ZLIB ON CACHE BOOL "Disable ZLIB compression")
	set(MZ_BZIP2 OFF CACHE BOOL "Disable BZIP2 compression")
	set(MZ_LZMA OFF CACHE BOOL "Disable LZMA & XZ compression")
	set(MZ_PKCRYPT OFF CACHE BOOL "Disable PKWARE traditional encryption")
	set(MZ_WZAES OFF CACHE BOOL "Disable WinZIP AES encryption")
	set(MZ_ZSTD OFF CACHE BOOL "Disable ZSTD compression")
	set(MZ_SIGNING OFF CACHE BOOL "Disable zip signing support")

	add_subdirectory(${PROJECT_SOURCE_DIR}/thirdparty/minizip minizip)
	set(minizip_FOUND 1 PARENT_SCOPE)
endif()

[GeckoEidechse]

Given that minizip is only used for the not officially release mod-auto-download, I think we can be a lot more lax with review requirements on this PR ^^

[Jan200101]

commited, rebased and merged (because why not)
Can be merged and released when ready

[Alystrasz]

Confirmed working as described in #602 (review).

[GeckoEidechse]

Merging based on reviews