Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ban/kick concommand completion #604

Merged
merged 14 commits into from
Jan 4, 2024
Merged

Add ban/kick concommand completion #604

merged 14 commits into from
Jan 4, 2024

Conversation

catornot
Copy link
Member

just adds completion to ban, kick and unban commands.

image

how test this ??????

try banning, kicking and unbanning someone from the in game console, it should display the closest uid/name to what you typed in :)

@GeckoEidechse GeckoEidechse added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 28, 2023
@catornot
Copy link
Member Author

catornot commented Dec 4, 2023

huh build failed to configure cmake?

@GeckoEidechse
Copy link
Member

GeckoEidechse commented Dec 5, 2023 •
edited
Loading

huh build failed to configure cmake?

minizip apparently has a remote dependency on https://sourceware.org/ which was down at the time xD

@GeckoEidechse GeckoEidechse mentioned this pull request Dec 21, 2023
Merged
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 27, 2023
@catornot catornot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 29, 2023
ASpoonPlaysGames
ASpoonPlaysGames approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks aight to me, would be cool to figure out what those flags are.

Would also be cool if unban would parse banlist or something, since going through the connected players for unban command completion is a bit dumb...

@GeckoEidechse
Revert command completion for unban
a40fef6 
Command completion is done based on players on the server. `unban` is used on banned players which by definition cannot be on the server.
GeckoEidechse
GeckoEidechse approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda forgot to mention that I already tested this PR and it worked as expected ^^

@ASpoonPlaysGames ASpoonPlaysGames changed the title Add ban/kick/unban concommand completion Add ban/kick concommand completion Jan 4, 2024
@GeckoEidechse GeckoEidechse added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jan 4, 2024
@GeckoEidechse GeckoEidechse merged commit f98513d into R2Northstar:main Jan 4, 2024
3 checks passed
@catornot catornot deleted the kick_completion branch January 5, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

@ASpoonPlaysGames ASpoonPlaysGames ASpoonPlaysGames approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catornot @GeckoEidechse @ASpoonPlaysGames