Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Move player auth to CServer::ConnectClient (#548)" #610

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Revert "Move player auth to CServer::ConnectClient (#548)" #610

merged 1 commit into from
Dec 1, 2023

Conversation

GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse commented Dec 1, 2023 •
edited
Loading

This reverts commit 17217a3 (PR #548) which introduced a regression allowing auth to progress further than intended.

GeckoEidechse
GeckoEidechse commented Dec 1, 2023
View reviewed changes
Copy link
Member Author

@GeckoEidechse GeckoEidechse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested myself and confirmed regression fixed.

RoyalBlue1
RoyalBlue1 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@RoyalBlue1 RoyalBlue1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert to previous code

@GeckoEidechse GeckoEidechse merged commit a27c702 into main Dec 1, 2023
5 checks passed
@GeckoEidechse GeckoEidechse deleted the fix/auth-error branch December 1, 2023 20:31
GeckoEidechse added a commit that referenced this pull request Dec 1, 2023
@GeckoEidechse
Revert "Move player auth to CServer::ConnectClient (#548)" (#610)
9c35f10 
This reverts commit 17217a3 (PR #548) which introduced a regression allowing auth to progress further than intended.

(cherry picked from commit a27c702)
@GeckoEidechse GeckoEidechse mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoyalBlue1 RoyalBlue1 RoyalBlue1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeckoEidechse @RoyalBlue1