Cherry pick "remove unnecessary namespaces" from primedev #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASpoonPlaysGames
added
needs testing
GeckoEidechse
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Played a few rounds of multiplayer and SP with this and didn't notice any issues.
As for code review, as far as I saw the PR does what it says and just drops the Tier0 and R2 namespaces entirely.
However in regards to code review, I'd still love a second input.
GeckoEidechse
removed
the
needs testing
F1F7Y
approved these changes
Dec 20, 2023
uniboi
pushed a commit
to uniboi/NorthstarLauncher
that referenced
this pull request
Dec 21, 2023
…r#618) Cherry-picks the removal of unnecessary namespaces from `primedev` https://github.com/F1F7Y/NorthstarPrime/ Co-authored-by: F1F7Y <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boy i sure do hope that some of these PRs get merged, since cherry picking the changes gets harder the further down i go