Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .def for function exports #625

Merged
merged 17 commits into from
Jan 3, 2024
Merged

Use .def for function exports #625

merged 17 commits into from
Jan 3, 2024

Conversation

ASpoonPlaysGames
Copy link
Contributor

Depends on #624

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code depends on another PR Blocked until the PR it depends on is merged labels Dec 21, 2023
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 27, 2023
@github-actions github-actions bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 30, 2023
GeckoEidechse
GeckoEidechse approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is basically a tiny refactor that doesn't affect logic, no in-game testing should be needed for this.

As for code review, .def is an MSVC thing but given that wsock32 stuff also uses it, not an issue IMO.

@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code depends on another PR Blocked until the PR it depends on is merged labels Jan 3, 2024
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jan 3, 2024
@github-actions github-actions bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Jan 3, 2024
@GeckoEidechse GeckoEidechse merged commit dcf6e1b into R2Northstar:main Jan 3, 2024
2 checks passed
@ASpoonPlaysGames ASpoonPlaysGames deleted the primedev-refactor/def-files branch January 4, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ASpoonPlaysGames @GeckoEidechse @F1F7Y