-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework MAD cleanup
handles
#817
Rework MAD cleanup
handles
#817
Conversation
Waiting for #815 to be merged so we have a simple way to cancel MAD process. |
Tested on NorthstarCN v1.18 branch and it works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mod directory doesn't seem to get removed when cancelling extract
https://github.com/user-attachments/assets/1932a97b-5df1-4fef-90fa-d0ab6940ae01
Edit: turns out there was an extra Northstar.dll
in my profile folder and it was messing with my testing. See the updated review below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, both the archive and the mod folder get deleted during the download/extract processes
2024-11-28.20-13-35.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code looks good
I don't have the opportunity rn to give this is a proper review. I trust @Alystrasz with the suggested change here, especially as @NachosChipeados confirmed it working in testing. As such merging rn without further reviews. |
cleanup
handlescleanup
handles
Changes
Testing
allow_mod_auto_download 1
);runtime/remote/mods
directory;C:\Users\Remy\AppData\Local\Temp
), there should be no mod archive.Closes #756.
TODOs