server: Remove uses of Autohook from serverauthentication.cpp
#820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
F1F7Y
added
almost ready to merge
GeckoEidechse
approved these changes
Oct 30, 2024
GeckoEidechse
changed the title
serverauthentication.cppserverauthentication.cpp
wolf109909
pushed a commit
to R2NorthstarCN/NorthstarLauncher
that referenced
this pull request
Nov 12, 2024
…rthstar#820) Manually hook - `CBaseServer__ConnectClient` - `CBaseClient__Connect` - `CBaseClient__ActivatePlayer` - `CBaseClient__Disconnect` Remove `AUTOHOOK_INIT` and `AUTOHOOK_DISPATCH`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review:
o_pso any times where the old AUTOHOOK was calling the original function it should now be calling that instead.h_so any times where we would be wanting to call the hooked function from other functions should now be calling that insteadCBaseClient__Disconnectin another file as well, hence the weird name on the original hook. Potentially any calls we were making toCBaseClient__Disconnectinstead of_CBaseClient__Disconnectare bypassing the hook? Something worth investigating at some point, shouldn't affect this PR though.Testing: