Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate sqvm destroy log #822

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

uniboi
Copy link
Contributor

@uniboi uniboi commented Sep 12, 2024

It's logged in server.dll somewhere already I believe and doesn't make sense to repeat this for every loaded plugin

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 12, 2024
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already logged in DestroyVMHook

@F1F7Y F1F7Y merged commit f9a9798 into R2Northstar:main Sep 12, 2024
6 checks passed
@uniboi uniboi deleted the useless-log branch September 12, 2024 11:10
@GeckoEidechse GeckoEidechse changed the title remove useless log Remove duplicate sqvm destroy log Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants