refactor: Mod information file export #832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
NachosChipeados
approved these changes
Dec 2, 2024
GeckoEidechse
added
almost ready to merge
| @@ -628,6 +619,28 @@ void ModManager::SearchFilesystemForMods() | |||
| std::sort(m_LoadedMods.begin(), m_LoadedMods.end(), [](Mod& a, Mod& b) { return a.LoadPriority < b.LoadPriority; }); | |||
| } | |||
|
|
|||
| void ModManager::ExportModsConfigurationToFile() | |||
| { | |||
| m_EnabledModsCfg.SetObject(); | |||
There was a problem hiding this comment.
Does m_EnabledModsCfg.SetObject(); have to be set again here?
(I don't think I fully understand what that line does... ^^)
There was a problem hiding this comment.
It resets the state of the m_EnabledModsCfg object (same as dict = {} in js for instance)
|
(on Holiday for a few days, maybe someone else could take care of code review to get this merged?) |
NachosChipeados
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two refactor changes here (one per commit):
enabledmods.jsonpath (moved to header file);enabledmods.jsoncreation logic into newExportModsConfigurationToFilemethod (with associated documentation).