Fix reloading plugins #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
|
Seemingly it was only an issue of discord rpc not reloading, every other plugins works so this pr can be reviewed now :D |
uniboi
approved these changes
Jan 9, 2025
uniboi
added
READY TO MERGE
|
not sure if this was actually tested or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally it probably worked if all plugins could be reloaded but it also just dropped all the plugins regardless of whether it can be reloaded or not.
So this pr attempts to amend that by individually reloading all the plugins instead of dropping then loading them all.
(this still doesn't really fix it since I can't get any plugin to be reloaded 💢 so that's why it's a draft)
was (wow crash)
now (wow still doesn't work!)
so basically I need some help but I think this pr is good first stepping stone. :)
ignore the screenshots before this
how to test
with this pr if upon reloading plugins nothing crashes then that means it worked as intended.