Prevent potential issues and crashes with HTTP requests. #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASpoonPlaysGames
approved these changes
Dec 21, 2022
Erlite
changed the title
|
not sure if this is necessarily a problem, but this being in script rather than native means that mods calling the internal functions directly for any reason would still play in demo, might be better to do this check in native? |
|
Having this check in native would be more elegant but I think this is fine for now |
F1F7Y
added
needs testing
|
Thr native check is at |
ASpoonPlaysGames
removed
the
feedback wanted
|
bump |
Alystrasz
reviewed
Nov 9, 2024
| @@ -89,6 +89,7 @@ void function NSHandleSuccessfulHttpRequest( int handle, int statusCode, string | |||
| response.statusCode = statusCode | |||
| response.body = body | |||
| response.rawHeaders = headers | |||
| response.headers = {} | |||
There was a problem hiding this comment.
I haven't worked with anything on the HTTP requests of Northstar yet, judging by those functions code i'm uncertain how their logic functions, especially if there's integration at Launcher side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent demos from replaying HTTP requests, and fix a random crash that occurred, although I do think it's just memory corruption from a broken Northstar install on my end, the callstack is odd.