Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI Notification for Invalid Mod Installs #597

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Add UI Notification for Invalid Mod Installs #597

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
81aace2
add invalid mod install notification
uniboi Feb 26, 2023
c70b8c4
add translation example
uniboi Feb 26, 2023
ce2e95f
requests from review
uniboi Feb 28, 2023
d05f1fe
display invalid mods on top of the modlist
uniboi Mar 2, 2023
1ddd4ef
Merge branch 'invalid-mod-installs' of github.com:uniboi/NorthstarMod…
uniboi Mar 2, 2023
8fcb543
use invalid mod names
uniboi Apr 3, 2023
0cbfa5f
update localization
uniboi Apr 3, 2023
2fda18c
include profile in expected path
uniboi Apr 3, 2023
746df7d
Merge branch 'main' of github.com:R2Northstar/NorthstarMods into inva…
uniboi May 7, 2023
dbb74b6
switch to new native mods api
uniboi May 7, 2023
f4bc407
add new functions to nativefuncs.json
uniboi May 7, 2023
4011dcb
store last selected panel for extra information
uniboi May 7, 2023
2b4fb8d
rename vars for more precision
uniboi May 7, 2023
ad3557a
use localized helptext for incorrect installs
uniboi May 7, 2023
093c0ee
mention mod.json in the expected & actual path
uniboi May 10, 2023
e90b091
Merge branch 'main' into invalid-mod-installs
uniboi May 14, 2023
8e73259
feat: add missing translations
Alystrasz May 22, 2023
f117ce0
Merge pull request #2 from Alystrasz/invalid-mods-i18n
uniboi May 22, 2023
65ff5be
italian translation
uniboi May 22, 2023
5404e37
Merge branch 'main' into invalid-mod-installs
uniboi May 28, 2023
3dc6607
Merge branch 'main' into invalid-mod-installs
uniboi May 30, 2023
4d4df93
russian & french translations
uniboi May 30, 2023
e94ae35
Merge branch 'main' into invalid-mod-installs
uniboi Jun 23, 2023
d2031a5
Merge branch 'main' into invalid-mod-installs
uniboi Jul 14, 2023
a649d20
Merge branch 'main' into invalid-mod-installs
uniboi Jul 16, 2023
fd3344b
Merge branch 'main' into invalid-mod-installs
uniboi Jul 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
162 changes: 33 additions & 129 deletions .github/nativefuncs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,58 +1,28 @@
{
"SERVER":[
{
"name":"NSGetModNames",
"helpText":"",
"returnTypeString":"array<string>",
"argTypes":""
},
{
"name":"NSIsModEnabled",
"helpText":"",
"returnTypeString":"bool",
"argTypes":"string modName"
},
{
"name":"NSSetModEnabled",
"helpText":"",
"returnTypeString":"void",
"argTypes":"string modName, bool enabled"
},
{
"name":"NSGetModDescriptionByModName",
"helpText":"",
"returnTypeString":"string",
"argTypes":"string modName"
},
{
"name":"NSGetModVersionByModName",
"helpText":"",
"returnTypeString":"string",
"argTypes":"string modName"
"argTypes":"int index, bool enabled"
},
{
"name":"NSGetModDownloadLinkByModName",
"helpText":"",
"returnTypeString":"string",
"argTypes":"string modName"
},
{
"name":"NSGetModLoadPriority",
"helpText":"",
"returnTypeString":"int",
"argTypes":"string modName"
"name":"NSGetMods",
"helpText":"Get all installed mods",
"returnTypeString":"array<Mod>",
"argTypes":""
},
{
"name":"NSIsModRequiredOnClient",
"helpText":"",
"returnTypeString":"bool",
"argTypes":"string modName"
"name":"NSGetInvalidMods",
"helpText":"Get all mods that are installed in a subfolder",
"returnTypeString":"array<Mod>",
"argTypes":""
},
{
"name":"NSGetModConvarsByModName",
"name":"NSReloadMods",
"helpText":"",
"returnTypeString":"array<string>",
"argTypes":"string modName"
"returnTypeString":"void",
"argTypes":""
},
{
"name":"DecodeJSON",
Expand Down Expand Up @@ -200,59 +170,29 @@
"returnTypeString":"void",
"argTypes":"int context, string text"
},
{
"name":"NSGetModNames",
"helpText":"",
"returnTypeString":"array<string>",
"argTypes":""
},
{
"name":"NSIsModEnabled",
"helpText":"",
"returnTypeString":"bool",
"argTypes":"string modName"
},
{
"name":"NSSetModEnabled",
"helpText":"",
"returnTypeString":"void",
"argTypes":"string modName, bool enabled"
"argTypes":"int index, bool enabled"
},
{
"name":"NSGetModDescriptionByModName",
"helpText":"",
"returnTypeString":"string",
"argTypes":"string modName"
},
{
"name":"NSGetModVersionByModName",
"helpText":"",
"returnTypeString":"string",
"argTypes":"string modName"
},
{
"name":"NSGetModDownloadLinkByModName",
"helpText":"",
"returnTypeString":"string",
"argTypes":"string modName"
},
{
"name":"NSGetModLoadPriority",
"helpText":"",
"returnTypeString":"int",
"argTypes":"string modName"
"name":"NSGetMods",
"helpText":"Get all installed mods",
"returnTypeString":"array<Mod>",
"argTypes":""
},
{
"name":"NSIsModRequiredOnClient",
"helpText":"",
"returnTypeString":"bool",
"argTypes":"string modName"
"name":"NSGetInvalidMods",
"helpText":"Get all mods that are installed in a subfolder",
"returnTypeString":"array<Mod>",
"argTypes":""
},
{
"name":"NSGetModConvarsByModName",
"name":"NSReloadMods",
"helpText":"",
"returnTypeString":"array<string>",
"argTypes":"string modName"
"returnTypeString":"void",
"argTypes":""
},
{
"name":"DecodeJSON",
Expand Down Expand Up @@ -358,59 +298,23 @@
"returnTypeString":"var",
"argTypes":"int promoDataKey"
},
{
"name":"NSGetModNames",
"helpText":"",
"returnTypeString":"array<string>",
"argTypes":""
},
{
"name":"NSIsModEnabled",
"helpText":"",
"returnTypeString":"bool",
"argTypes":"string modName"
},
{
"name":"NSSetModEnabled",
"helpText":"",
"returnTypeString":"void",
"argTypes":"string modName, bool enabled"
"argTypes":"int index, bool enabled"
},
{
"name":"NSGetModDescriptionByModName",
"helpText":"",
"returnTypeString":"string",
"argTypes":"string modName"
},
{
"name":"NSGetModVersionByModName",
"helpText":"",
"returnTypeString":"string",
"argTypes":"string modName"
},
{
"name":"NSGetModDownloadLinkByModName",
"helpText":"",
"returnTypeString":"string",
"argTypes":"string modName"
},
{
"name":"NSGetModLoadPriority",
"helpText":"",
"returnTypeString":"int",
"argTypes":"string modName"
},
{
"name":"NSIsModRequiredOnClient",
"helpText":"",
"returnTypeString":"bool",
"argTypes":"string modName"
"name":"NSGetMods",
"helpText":"Get all installed mods",
"returnTypeString":"array<Mod>",
"argTypes":""
},
{
"name":"NSGetModConvarsByModName",
"helpText":"",
"returnTypeString":"array<string>",
"argTypes":"string modName"
"name":"NSGetInvalidMods",
"helpText":"Get all mods that are installed in a subfolder",
"returnTypeString":"array<Mod>",
"argTypes":""
},
{
"name":"NSReloadMods",
Expand Down
5 changes: 5 additions & 0 deletions Northstar.Client/mod/resource/northstar_client_localisation_english.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,5 +321,10 @@ Press Yes if you agree to this. This choice can be changed in the mods menu at a
"INVALID_MASTERSERVER_TOKEN" "Invalid or expired masterserver token"
"JSON_PARSE_ERROR" "Error parsing json response"
"UNSUPPORTED_VERSION" "The version you are using is no longer supported"

// Incorrect Mod Installation
"INCORRECT_MOD_INSTALL_TOAST" "Some of your mods are incorrectly installed. Click here for more info."
"INCORRECT_MODS_MODLIST_HEADER" "Incorrectly Installed Mods (%s1)"
"INCORRECT_MOD_INSTALL_DESCRIPTION" "This mod is incorrectly installed. Every mod has a file called \"mod.json\" in its root directory, however for this mod it was not found.\n\nExpected location: %s1/mod.json\nFound location: %s2/mod.json\n\nMake sure both mod.json file and mod directory are direct children of your mod folder."
uniboi marked this conversation as resolved.
Show resolved Hide resolved
}
}
Loading