Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins v3 #652

Merged
merged 14 commits into from
Nov 6, 2023
Merged

Plugins v3 #652

merged 14 commits into from
Nov 6, 2023

Conversation

catornot
Copy link
Member

@catornot catornot commented Jun 18, 2023 •
edited by GeckoEidechse
Loading

@catornot catornot mentioned this pull request Jun 18, 2023
Merged
@ASpoonPlaysGames
Copy link
Contributor

Would it be feasible to remove the launcher -> Northstar.Client dependency by reworking presence? I think ideally it gets handled all in launcher, but if not I would prefer it gets split off into a different mod or something?

@catornot
Copy link
Member Author

Would it be feasible to remove the launcher -> Northstar.Client dependency by reworking presence?

launcher doesn't handle presence in v3, I want to move it to the drpc plugin.

I think ideally it gets handled all in launcher, but if not I would prefer it gets split off into a different mod or something?

It might be possible but some stuff is just easier to access on the sqvm.

@F1F7Y F1F7Y added the depends on another PR Blocked until the PR it depends on is merged label Jul 9, 2023
@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Aug 25, 2023
ASpoonPlaysGames
ASpoonPlaysGames approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, though I would prefer if Launcher didn't depend on Mods.

Then again, it already does for a lot of stuff so ehhhh

@ASpoonPlaysGames ASpoonPlaysGames removed the needs code review Changes from PR still need to be reviewed in code label Aug 25, 2023
@catornot
Copy link
Member Author

though I would prefer if Launcher didn't depend on Mods.

The discord rpc plugin depends on this now. Launcher doesn't handle presence anymore.

@ASpoonPlaysGames
Copy link
Contributor

The discord rpc plugin depends on this now. Launcher doesn't handle presence anymore.

Perhaps rename the NorthstarCodeCallback functions then? Since they aren't coming from Northstar itself but a plugin. Something like DiscordRPC_ as a prefix would work imo

ASpoonPlaysGames
ASpoonPlaysGames requested changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting stuff

Northstar.Client/mod/scripts/vscripts/presence/ui_presence.nut Outdated Show resolved Hide resolved
Northstar.Client/mod/scripts/vscripts/presence/cl_presence.nut Outdated Show resolved Hide resolved
Northstar.Client/mod/scripts/vscripts/presence/cl_presence.nut Outdated Show resolved Hide resolved
@ASpoonPlaysGames ASpoonPlaysGames added the waiting on changes by author Waiting on PR author to implement the suggested changes label Sep 2, 2023
@ASpoonPlaysGames ASpoonPlaysGames removed the waiting on changes by author Waiting on PR author to implement the suggested changes label Sep 12, 2023
@ASpoonPlaysGames
Copy link
Contributor

Just going to mention that afaik this PR does not depend directly on the Launcher PR (R2Northstar/NorthstarLauncher#472) but instead depends on R2Northstar/NorthstarDiscordRPC#10 (which does depend on R2Northstar/NorthstarLauncher#472)

Basically what I'm getting at is that this PR shouldn't block R2Northstar/NorthstarLauncher#472 but also cannot properly be tested without R2Northstar/NorthstarLauncher#472 and R2Northstar/NorthstarDiscordRPC#10

ASpoonPlaysGames
ASpoonPlaysGames requested changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some formatting

Northstar.Client/mod/scripts/vscripts/cl_northstar_client_init.nut Outdated Show resolved Hide resolved
Northstar.Client/mod/scripts/vscripts/cl_northstar_client_init.nut Outdated Show resolved Hide resolved
Northstar.Client/mod/scripts/vscripts/presence/ui_presence.nut Outdated Show resolved Hide resolved
Northstar.Client/mod/scripts/vscripts/presence/cl_presence.nut Outdated Show resolved Hide resolved
ASpoonPlaysGames
ASpoonPlaysGames approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

I'm ignoring the weird whitespace in some files because the whole file is wrong, so fixing is beyond the scope of this PR

Jan200101
Jan200101 approved these changes Oct 22, 2023
View reviewed changes
Copy link

@Jan200101 Jan200101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as part of the Launcher PR

@Jan200101 Jan200101 added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs testing Changes from the PR still need to be tested labels Oct 22, 2023
@GeckoEidechse GeckoEidechse mentioned this pull request Nov 2, 2023
Merged
GeckoEidechse
GeckoEidechse approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing together with R2Northstar/NorthstarLauncher#472 and R2Northstar/NorthstarDiscordRPC#10

Joined a bunch of servers and watched Discord activity status update

(No code review done in this review)

@Jan200101 Jan200101 added READY TO MERGE This mergeable right now and removed almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Nov 5, 2023
@GeckoEidechse GeckoEidechse merged commit c0e8a90 into R2Northstar:main Nov 6, 2023
3 checks passed
@GeckoEidechse GeckoEidechse mentioned this pull request Nov 6, 2023
Merged
@catornot catornot deleted the plugins-v3 branch November 6, 2023 02:37
@catornot catornot restored the plugins-v3 branch November 6, 2023 02:37
@GeckoEidechse GeckoEidechse mentioned this pull request Nov 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASpoonPlaysGames ASpoonPlaysGames ASpoonPlaysGames approved these changes

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

@Jan200101 Jan200101 Jan200101 approved these changes

Assignees
No one assigned
Labels
depends on another PR Blocked until the PR it depends on is merged READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@catornot @ASpoonPlaysGames @Jan200101 @GeckoEidechse @F1F7Y