Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove annoying recurring print from chatroom.nut #676

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Remove annoying recurring print from chatroom.nut #676

merged 8 commits into from
Oct 3, 2023

Conversation

JMM889901
Copy link
Contributor

@JMM889901 JMM889901 commented Jul 30, 2023 •
edited by GeckoEidechse
Loading

First commit is upload from vanilla

Adds chatroom.nut from englishclient_frontend and modifies it.

JMM889901 added 2 commits July 30, 2023 16:58
@JMM889901
Create chatroom.nut
777e411 
Upload from vanilla scripts
Frontend vpk
chatroom.nut
@JMM889901
The print in question
092f77f
ASpoonPlaysGames
ASpoonPlaysGames approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy shit yes please thank you oh my god (also, code looks good)

@ASpoonPlaysGames
Copy link
Contributor

First commit is upload from vanilla

you should mention which vpk this is from

@JMM889901
Copy link
Contributor Author

you should mention which vpk this is from

read first commit description :)

F1F7Y
F1F7Y requested changes Jul 30, 2023
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm nitpicking but imo it would be better to just comment it out instead of removing it out right

uniboi
uniboi approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@uniboi uniboi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise the lord

you should mention which vpk this is from

click the commit bruh it's right there

@ASpoonPlaysGames
Copy link
Contributor

click the commit bruh it's right there

(this is for gecko not for me)

@JMM889901
Update chatroom.nut
28b3937 
Commented out instead of fully removing
@JMM889901
Copy link
Contributor Author

I know I'm nitpicking but imo it would be better to just comment it out instead of removing it out right

👍 done

F1F7Y
F1F7Y approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@F1F7Y F1F7Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@GeckoEidechse
Copy link
Member

For completeness sake, maybe add sample log snippet that shows before/after change. That sorta stuff helps a lot with figuring out which PRs should get priority ;)

@JMM889901
Copy link
Contributor Author

image

before^

after is kinda hard to show since its just the absence of those prints

@JMM889901
Copy link
Contributor Author

boowomp

@ASpoonPlaysGames ASpoonPlaysGames added the READY TO MERGE This mergeable right now label Aug 19, 2023
EladNLG

This comment was marked as off-topic.

Sign in to view

@ASpoonPlaysGames ASpoonPlaysGames added the commits vanilla file For PRs that commit vanilla files from VPKs label Sep 2, 2023
@GeckoEidechse GeckoEidechse changed the title Remove annoying recurring print from chatroom.nut Remove annoying recurring print from chatroom.nut Oct 3, 2023
@GeckoEidechse
Copy link
Member

Merging based on previous reviews. Made sure to commit vanilla file to main separately first.

@GeckoEidechse GeckoEidechse merged commit 1226f75 into R2Northstar:main Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse left review comments

@ASpoonPlaysGames ASpoonPlaysGames ASpoonPlaysGames approved these changes

@F1F7Y F1F7Y F1F7Y approved these changes

@uniboi uniboi uniboi approved these changes

@EladNLG EladNLG EladNLG left review comments

Assignees
No one assigned
Labels
commits vanilla file For PRs that commit vanilla files from VPKs READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JMM889901 @ASpoonPlaysGames @GeckoEidechse @EladNLG @uniboi @F1F7Y