Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing Score Events #700

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Implement missing Score Events #700

merged 11 commits into from
Nov 21, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

closes #661

Uses a decent amount of the vanilla stuff in _entitystructs.gnut but not everything

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 3, 2023
Zanieon
Zanieon approved these changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@Zanieon Zanieon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and testing worked fine.

@ASpoonPlaysGames ASpoonPlaysGames added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 20, 2023
@GeckoEidechse
Copy link
Member

Merging based on reviews

@GeckoEidechse GeckoEidechse merged commit 4e394ce into R2Northstar:main Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zanieon Zanieon Zanieon approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Score Events
3 participants
@ASpoonPlaysGames @GeckoEidechse @Zanieon