Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent client side crash in MFD when marked target dies out of bounds. #705

Merged
merged 5 commits into from
Jan 21, 2024
Merged

Prevent client side crash in MFD when marked target dies out of bounds. #705

merged 5 commits into from
Jan 21, 2024

Conversation

ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames commented Sep 7, 2023 •
edited by GeckoEidechse
Loading

This should close #474

This will need proper testing though, as I have not tested it myself (need more than 1 person)

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code vanilla parity labels Sep 7, 2023
NoCatt
NoCatt approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@NoCatt NoCatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after a small discussion in the discord, we found and additional bug in line 199 and also added a bool for isSuicide because we need it more than once ( duh ).

@ASpoonPlaysGames ASpoonPlaysGames removed the needs code review Changes from PR still need to be reviewed in code label Sep 18, 2023
GeckoEidechse
GeckoEidechse approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing.

Spawned an MFD server with two players.

Before this PR, having a marked player die out-of-bounds would crash the server.
With this PR, repeating the same test the server stays alive.

@GeckoEidechse
Copy link
Member

Also unrelated whitespace change >:(

But I digress :P

@GeckoEidechse GeckoEidechse removed the needs testing Changes from the PR still need to be tested label Jan 21, 2024
@GeckoEidechse GeckoEidechse merged commit 7edb0f2 into R2Northstar:main Jan 21, 2024
3 checks passed
@ASpoonPlaysGames ASpoonPlaysGames deleted the mfd-crash branch January 27, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoCatt NoCatt NoCatt approved these changes

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
vanilla parity
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MFD client crash for everyone if marked target dies out of bounds
3 participants
@ASpoonPlaysGames @GeckoEidechse @NoCatt