Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial unit testing logic #708

Merged
merged 16 commits into from
Apr 11, 2024

Conversation

ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames commented Sep 13, 2023

Doesn't currently use compiler flags or anything but whatever, it works and stuff

closes #707

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 13, 2023
Copy link
Contributor

@uniboi uniboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works in testing. Unfortunately can't be abstracted further and is a bit fiddly because complex types can never be var
(unless someone writes a plugin)

@ASpoonPlaysGames
Copy link
Contributor Author

I think that personally I would prefer if unit testing was eventually done via a plugin, but I think that this is a good enough solution for now.

I also don't really see unit testing being used all that much. Most of our functions return void, just doing some work. The option to use unit testing is nice though for some cases

@uniboi
Copy link
Contributor

uniboi commented Sep 14, 2023

Yeah unfortunately the actual game is too complex to thoroughly test, just think about entities dread

@ASpoonPlaysGames ASpoonPlaysGames added feedback wanted Feedback is wanted whether the changes by this PR are desired READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 18, 2023
@ASpoonPlaysGames
Copy link
Contributor Author

closes #707

@GeckoEidechse GeckoEidechse changed the title Unit testing and stuff Add initial unit testing logic Apr 11, 2024
@GeckoEidechse GeckoEidechse merged commit f427583 into R2Northstar:main Apr 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted Feedback is wanted whether the changes by this PR are desired READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Automated testing/Unit testing
4 participants