Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing server browser localisation for WRONG_MOD_VERSION #710

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Add missing server browser localisation for WRONG_MOD_VERSION #710

merged 6 commits into from
Dec 20, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

Closes #629

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 14, 2023
@GeckoEidechse GeckoEidechse changed the title add missing server browser localisation Add missing server browser localisation Dec 14, 2023
@GeckoEidechse GeckoEidechse self-requested a review December 14, 2023 00:53
@GeckoEidechse GeckoEidechse added the almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge label Dec 14, 2023
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 20, 2023
@GeckoEidechse
Copy link
Member

@ASpoonPlaysGames merge conflicts atm :c

@GeckoEidechse GeckoEidechse removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 20, 2023
@GeckoEidechse
Copy link
Member

GeckoEidechse commented Dec 20, 2023 •
edited
Loading

To test: Simply install https://northstar.thunderstore.io/package/odds/s2space/ and then change its MAJOR version number. Afterwards, join the Space Battle server and see if the error message shows up correctly.

EDIT: Nevermind, apparently that version check no longer exists?

GeckoEidechse
GeckoEidechse approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so turns out version check is fucked rn for some reason so I cannot get the error message to show.

That being said, the change looks obvious and correct so I'm gonna approve this even with technically insufficient testing.

@GeckoEidechse GeckoEidechse changed the title Add missing server browser localisation Add missing server browser localisation for WRONG_MOD_VERSION Dec 20, 2023
@GeckoEidechse GeckoEidechse merged commit feee261 into R2Northstar:main Dec 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoCatt NoCatt NoCatt requested changes

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing localisation in server browser
3 participants
@ASpoonPlaysGames @GeckoEidechse @NoCatt