Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix localisation string for toggling progression on controller #717

Merged
merged 4 commits into from
Oct 8, 2023
Merged

Fix localisation string for toggling progression on controller #717

merged 4 commits into from
Oct 8, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames commented Sep 22, 2023 •
edited by GeckoEidechse
Loading

closes #716

Other languages don't have an entry for this localisation, so I didn't change them

Testing:

  1. go into the lobby
  2. plug in a controller
  3. notice that the "Toggle Progression" button is still there with a controller button image

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 22, 2023
Jan200101
Jan200101 approved these changes Sep 22, 2023
View reviewed changes
Copy link

@Jan200101 Jan200101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested because I'm stuck in the Windows mines, but looks good.

Matches whats done in the controller prompts script

NorthstarMods/Northstar.Client/mod/scripts/vscripts/ui/controller_prompts.nut

Line 9 in 6bfd52b

return "%[Y_BUTTON|]%"

@ASpoonPlaysGames ASpoonPlaysGames removed the needs code review Changes from PR still need to be reviewed in code label Sep 22, 2023
Jan200101
Jan200101 approved these changes Oct 7, 2023
View reviewed changes
Copy link

@Jan200101 Jan200101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 2
Electric Boogaloo

Prompt shows up properly (and works by pressing the relevant button, but that is not part of this PR)

grafik

@ASpoonPlaysGames ASpoonPlaysGames added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested labels Oct 7, 2023
GeckoEidechse
GeckoEidechse approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing-off based on other reviews. Didn't much look at it. I just hope someone checked that all language files were updated ^^"

@GeckoEidechse GeckoEidechse merged commit 89c0d98 into R2Northstar:main Oct 8, 2023
3 checks passed
@GeckoEidechse GeckoEidechse added the progression Changes related to progression system label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

@Jan200101 Jan200101 Jan200101 approved these changes

Assignees
No one assigned
Labels
progression Changes related to progression system READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Toggle Progression" button doesn't appear when using controller
3 participants
@ASpoonPlaysGames @Jan200101 @GeckoEidechse