Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RequiredOnClient text clearer #720

Merged

Conversation

ASpoonPlaysGames
Copy link
Contributor

closes #673

Also actually makes that text get localised because it wasn't doing that

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 23, 2023
Co-authored-by: uniboi <[email protected]>
@GeckoEidechse GeckoEidechse changed the title Make RequiredOnClient text clearer Make RequiredOnClient text clearer Dec 17, 2023
@GeckoEidechse
Copy link
Member

I wanted to quickly just open the game with the PR to check the warning message but I cannot actually find where the message pops up ^^"

@ASpoonPlaysGames
Copy link
Contributor Author

I wanted to quickly just open the game with the PR to check the warning message but I cannot actually find where the message pops up ^^"

Mods list menu, when you hover over a RequiredOnClient mod iirc, should be in the bottom right

Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing I guess

image

The changes are also pretty self-explanatory.

@GeckoEidechse GeckoEidechse removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Dec 19, 2023
@GeckoEidechse GeckoEidechse merged commit bbd4ced into R2Northstar:main Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

RequiredOnClient warning text is not very clear
3 participants