Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move leeched NPCs over to the player's new team when they change team #721

Closed
wants to merge 7 commits into from
Closed

Move leeched NPCs over to the player's new team when they change team #721

wants to merge 7 commits into from

Conversation

ASpoonPlaysGames
Copy link
Contributor

closes #649 (the other part of that should be fixed already by other changes)

side note: i have no idea what happened to the commit history here wtf?

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 23, 2023
@GeckoEidechse
Copy link
Member

"Leeched NPCs" are things like hacked Spectres, right?

@ASpoonPlaysGames
Copy link
Contributor Author

"Leeched NPCs" are things like hacked Spectres, right?

yeah

@EM4Volts
Copy link
Contributor

tested ingame, works.
spawned a hacked spectre, switched team, spectre switched over with me.

@ASpoonPlaysGames ASpoonPlaysGames removed the needs testing Changes from the PR still need to be tested label Oct 21, 2023
Alystrasz
Alystrasz approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leeched NPCs don't attack master player anymore after they swapped teams.

Command used to create and attach a spectre: ent_create npc_spectre; script DoLeech(GetNPCArrayByClass("npc_spectre")[0], GetPlayerArray()[0])

@Zanieon Zanieon mentioned this pull request Feb 5, 2024
Merged
@Zanieon
Copy link
Contributor

Zanieon commented Jun 29, 2024

This should be closed as #789 was merged and serves the same purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alystrasz Alystrasz Alystrasz approved these changes

Assignees
No one assigned
Labels
needs code review Changes from PR still need to be reviewed in code
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hacked spectres causing a server crash in Attrition
5 participants
@ASpoonPlaysGames @GeckoEidechse @EM4Volts @Zanieon @Alystrasz