Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent loadout validation crash due to invalid warpaints #734

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Prevent loadout validation crash due to invalid warpaints #734

merged 2 commits into from
Oct 4, 2023

Conversation

ASpoonPlaysGames
Copy link
Contributor

MoreSkins yet again causing problems lol

@ASpoonPlaysGames ASpoonPlaysGames added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 4, 2023
@NoCatt
Copy link
Contributor

NoCatt commented Oct 4, 2023

I ran the test server and I can thus confirm it doesnt crash, code does look a bit on the hacky unreadable side. but this is a LOT better than overriting respawn files

@ASpoonPlaysGames ASpoonPlaysGames removed the needs testing Changes from the PR still need to be tested label Oct 4, 2023
GeckoEidechse
GeckoEidechse approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving this a quick skim I don't see any obvious errors. Not really a "full" code review but good enough ig ¯\_(ツ)_/¯

@GeckoEidechse GeckoEidechse changed the title prevent loadout validation crash due to invalid warpaints Prevent loadout validation crash due to invalid warpaints Oct 4, 2023
@GeckoEidechse GeckoEidechse merged commit 1c3bafd into R2Northstar:main Oct 4, 2023
@ASpoonPlaysGames ASpoonPlaysGames added READY TO MERGE This mergeable right now and removed needs code review Changes from PR still need to be reviewed in code labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoCatt NoCatt NoCatt approved these changes

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ASpoonPlaysGames @NoCatt @GeckoEidechse