-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Titan Assist not tracking properly #744
Conversation
This reverts commit a1ea16b.
Co-authored-by: Jack <[email protected]>
Github actions having a moment, so I'm making a random whitespace change to trigger it again
Co-authored-by: Jack <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I'm not a fan of handling assist stats in _score.nut
. I would prefer if the awarding of assistsTotal
that is already done in _stats.nut
was updated to handle this edge case. I'm probably going to make a PR for this stats change.
The other change looks good at first glance though. I'll approve this PR once the stats stuff has been either moved or removed from this PR
Done, stat tracking removed from medal code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good :)
Did anyone test this? ^^" |
Sorry, i did, before and after the request changed by Spoon, hence why i changed label ready to merge. Ill comment that i tested when labelling PRs as ready to merge if they need to be re-tested after changes from suggestions. |
Awesome, thanks for confirming <3 |
@Zanieon said it should be fine to merge as is. |
Titan Assist medals aren't given to players who assisted damage when someone kills a titan, that is due the fact that Titans stores damage history in their Soul component, not the NPC itself, probably due to how game handles pilot/auto-titan interaction with the Titan entities.
I know it's ideal to PR for every single minuscle thing, but with this i also fixed the stat tracking of assistances done with weapons for progression unlocks, only because it all resides inside the same block of code that i needed to change for this whole fix.- split into #746