Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Titan Assist not tracking properly #744

Merged
merged 21 commits into from
Oct 18, 2023

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Oct 13, 2023

Titan Assist medals aren't given to players who assisted damage when someone kills a titan, that is due the fact that Titans stores damage history in their Soul component, not the NPC itself, probably due to how game handles pilot/auto-titan interaction with the Titan entities.

I know it's ideal to PR for every single minuscle thing, but with this i also fixed the stat tracking of assistances done with weapons for progression unlocks, only because it all resides inside the same block of code that i needed to change for this whole fix. - split into #746

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm not a fan of handling assist stats in _score.nut. I would prefer if the awarding of assistsTotal that is already done in _stats.nut was updated to handle this edge case. I'm probably going to make a PR for this stats change.

The other change looks good at first glance though. I'll approve this PR once the stats stuff has been either moved or removed from this PR

@Zanieon
Copy link
Contributor Author

Zanieon commented Oct 14, 2023

Done, stat tracking removed from medal code.

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good :)

@Zanieon Zanieon added the READY TO MERGE This mergeable right now label Oct 14, 2023
@GeckoEidechse
Copy link
Member

Did anyone test this? ^^"

@Zanieon
Copy link
Contributor Author

Zanieon commented Oct 16, 2023

Did anyone test this? ^^"

Sorry, i did, before and after the request changed by Spoon, hence why i changed label ready to merge. Ill comment that i tested when labelling PRs as ready to merge if they need to be re-tested after changes from suggestions.

@GeckoEidechse
Copy link
Member

Did anyone test this? ^^"

Sorry, i did, before and after the request changed by Spoon, hence why i changed label ready to merge.

Awesome, thanks for confirming <3
Usually we would also get someone else other than the PR author to test it to prevent a "works on my machine" moment, though I'd be fine with skipping that for this PR if we want to ^^

@GeckoEidechse
Copy link
Member

@Zanieon said it should be fine to merge as is.

@GeckoEidechse GeckoEidechse merged commit aa79ad4 into R2Northstar:main Oct 18, 2023
3 checks passed
@Zanieon Zanieon deleted the maintenance_main branch October 19, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants