-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mod download UI integration #761
Conversation
I believe the compile check does not pass due to updated |
Looks like you added your new native funcs to the |
Good catch, thanks! |
Regarding:
I'm not sure if I already mentioned this in our discussion. Basically I would make the barrier to enabling it a bit more difficult then a switch in settings. Personally tending towards a CLI arg rn. The main reason is that, we don't want too many players start using it before we feel it's ready. Auto-mod-download is a huge feature in terms of impact on Northstar so we want to make it "splash" when we release it. Think hype-up trailer and everything. And that also requires having some content for it. |
Alternative to CLI arg would be setting a convar value manually or having a mod on Thunderstore that flips the switch to enable the feature. Basically something a tad less accessible for players while we are still fleshing out the functionality and content ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting mostly
Northstar.Client/mod/resource/northstar_client_localisation_english.txt
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_moddownload.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_moddownload.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_moddownload.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_moddownload.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_moddownload.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_moddownload.nut
Outdated
Show resolved
Hide resolved
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
Co-authored-by: Jack <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me
NorthstarMods
counterpart of R2Northstar/NorthstarLauncher#595For any comments unrelated to this mods PR, please post on the launcher PR (to keep all discussions on one page).
Changes
Commands
menu to enable mod downloading, this is meant to easily allow players to test the feature;DownloadMod
function triggers mod downloading, and displays progress in an alert dialog;TODOs
Activate remote mod if it's required by a server and already downloaded, but not activated(remote mods are enabled by default by current mod system)