Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod download UI integration #761

Merged
merged 51 commits into from
Dec 14, 2023
Merged

Conversation

Alystrasz
Copy link
Contributor

@Alystrasz Alystrasz commented Nov 12, 2023

NorthstarMods counterpart of R2Northstar/NorthstarLauncher#595

For any comments unrelated to this mods PR, please post on the launcher PR (to keep all discussions on one page).

Changes

  • Adds an option in the Commands menu to enable mod downloading, this is meant to easily allow players to test the feature;
  • DownloadMod function triggers mod downloading, and displays progress in an alert dialog;
  • If some mods have been downloaded, reload mods.

TODOs

  • Add English translations
  • Activate remote mod if it's required by a server and already downloaded, but not activated (remote mods are enabled by default by current mod system)
  • Expose a test server running a custom map endlessly

@Alystrasz
Copy link
Contributor Author

I believe the compile check does not pass due to updated nativefuncs.json

@ASpoonPlaysGames
Copy link
Contributor

I believe the compile check does not pass due to updated nativefuncs.json

Looks like you added your new native funcs to the SERVER section of nativefuncs.json instead of UI

@Alystrasz
Copy link
Contributor Author

I believe the compile check does not pass due to updated nativefuncs.json

Looks like you added your new native funcs to the SERVER section of nativefuncs.json instead of UI

Good catch, thanks!

@GeckoEidechse
Copy link
Member

Regarding:

  • Adds an option in the Commands menu to enable mod downloading, this is meant to easily allow players to test the feature;

I'm not sure if I already mentioned this in our discussion. Basically I would make the barrier to enabling it a bit more difficult then a switch in settings. Personally tending towards a CLI arg rn. The main reason is that, we don't want too many players start using it before we feel it's ready. Auto-mod-download is a huge feature in terms of impact on Northstar so we want to make it "splash" when we release it. Think hype-up trailer and everything. And that also requires having some content for it.
If however majority of players already start enabling it right now where there's basically no content for it yet, the sudden impact on global enable is a lot smaller and as such has less of an effect...

@GeckoEidechse
Copy link
Member

Alternative to CLI arg would be setting a convar value manually or having a mod on Thunderstore that flips the switch to enable the feature.

Basically something a tad less accessible for players while we are still fleshing out the functionality and content ^^

@GeckoEidechse GeckoEidechse changed the title feat: Mod download UI integration Mod download UI integration Dec 14, 2023
@GeckoEidechse GeckoEidechse added the depends on another PR Blocked until the PR it depends on is merged label Dec 14, 2023
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting mostly

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me

@GeckoEidechse GeckoEidechse merged commit e49e7e8 into R2Northstar:main Dec 14, 2023
3 checks passed
@GeckoEidechse GeckoEidechse added READY TO MERGE This mergeable right now and removed depends on another PR Blocked until the PR it depends on is merged almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Dec 14, 2023
@Alystrasz Alystrasz deleted the feat/auto-dl branch December 27, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants