Add Winter holiday event models to the lobby

[RoyalBlue1]

Models will be shown from 18.12. to the 06.01.

the tree model is from r5 and modified by 4Volt
The other models are from 4Volt

Co-authored-by: @EM4Volts

[ASpoonPlaysGames]

Changes mostly look good, just some incorrect formatting.

I'm not a fan of the multiple rpaks approach, but this has been discussed on discord (4v doesn't want to use the RePak refactor until it has a github release)

[Alystrasz]

Apart from formatting, this looks good.
I could test this by modifying the date, and verify new models appear in the lobby.

Private lobby menu is however hard to read white-on-white, I don't know how this could be fixed (rotating the camera upwards maybe? Adding another present just below menu position?)

[GeckoEidechse]

(bikesheddding)
A bunch of newly added files are missing trailing newlines

[EM4Volts]

Private lobby menu is however hard to read white-on-white, I don't know how this could be fixed (rotating the camera upwards maybe? Adding another present just below menu position?)

i think blue tried looking into moving cam or something. in the end we decided on sticking with this. since one menu is usable in other menus aswell, and the other is the store which isnt usable anyway. its a small time window and u can also still use the menu if u hover over it as the button label colors change then.

[catornot]

i think blue tried looking into moving cam or something. in the end we decided on sticking with this. since one menu is usable in other menus aswell, and the other is the store which isnt usable anyway. its a small time window and u can also still use the menu if u hover over it as the button label colors change then.

you should be able to edit the camera position with by moving menu_camera_target and menu_scene_ref.

[RoyalBlue1]

the camera is set through animations so we have 2 Options
1 use one of the other animations
2 modify the animation
both are not really that good of an option and without writing a whole new api changing it would do it permanently

[ASpoonPlaysGames]

Code looks good enough, missing some localisation but this is a bit time sensitive so yeah

[EM4Volts]

the camera is set through animations so we have 2 Options 1 use one of the other animations 2 modify the animation both are not really that good of an option and without writing a whole new api changing it would do it permanently

i dont think changing it would be bad. maybe we can sit together in the coming days and work out a solution for it.
currently the vanilla screen is just blank aswell so changing the camera to maybe face 180 degree wouldnt really change what stuff looks like

[ASpoonPlaysGames]

Code looks good

[EM4Volts]

"needs testing" just tested by changing the dates in script to trigger early. works.

[GeckoEidechse]

missing some localisation

Missing localisations are easier to add post-merge actually as they are picked up by weblate which is way more accessible to non-developers than GitHub anyway ^^

[ASpoonPlaysGames]

Missing localisations are easier to add post-merge actually as they are picked up by weblate which is way more accessible to non-developers than GitHub anyway ^^

Nah, because like its just using string literals, so it can't be localised atm.

We can still just fix this later very easily but yeah

[GeckoEidechse]

Requests from reviews have been addressed.