-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FD branch #777
Merged
Merged
Update FD branch #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRs from forks are triggered from that fork which means that they don't have access to the necessary token
Currently dropships take damage from titans stepping on them, this prevents that Co-authored-by: William Miller <[email protected]>
Titans stores damage history in their Soul component, not the NPC itself, probably due to how game handles pilot/auto-titan interaction with the Titan entities. This means that we weren't awarding assist stats properly for titan assists
Fixes an issue where dying while the Arc Cannon beam is hurting someone would cause an error. Co-authored-by: Dinorush <[email protected]>
Titan Assist medals aren't given to players who assisted damage when someone kills a titan, that is due the fact that Titans stores damage history in their Soul component, not the NPC itself.
Some game modes like Gun Game or Infection are not considered valid yet, causing the warning message to be spammed in the logs. Necessary work should be done to add the modes to the list of valid modes. Until we will just comment out the print statement in order to prevent log spam. Co-authored-by: GeckoEidechse <[email protected]>
Fix the add to project workflow so that it works on PRs from forks, securely by running it in the context of the target.
Gun game was never set up to properly use the playlistvars for setting guns, and relied on playlistvaroverrides to set the score limit, this caused the change to persist to other modes
Also doesn't show the challenge completion notifications in game as a nice side effect
Small fix which the wrong item type was being addressed to check for Titan Camos, allowing players to use any camo without fallback to default if they didn't own that item previously when enabling progression.
Fixes wrong attacker receiving stat updates
As currently Northstar does not support launching into vanilla.
Adds a new callback: `SetCallback_TryUseProjectileReplay` so that servers can write logic to enable/disable this behaviour on a case by case basis
Script component of plugins v3. See launcher PR for more info. R2Northstar/NorthstarLauncher#472
Translated using Weblate (French) Currently translated at 100.0% (291 of 291 strings) Translation: Northstar/Northstar Client Localisation Translate-URL: https://translate.harmony.tf/projects/northstar/client/fr/ Co-authored-by: Rémy Raes <[email protected]>
Add translation status indicator badge to README Add section showing all languages
* use consts for killingspree and rampage score events * add Revenge and Quick Revenge score events * ensure no revenge/quick revenge against non-players * this is OnPlayerKilled i dont need this check * implement mayhem and onslaught
Requesting for invalid loadout index using SwapSecondaryAndWeapon3PersistentLoadoutData will cause a crash. This change just adds a check to reset the loadout index.
This is an initial test to get formatting etc agreed upon to then build on this further
Adds decorative models to the lobby map that will only display during winter holiday season.
Adds a console command to allow players to reset the Aegis Ranks of their Titans
UI integration for the mod downloading feature. Feature activation locked behind a convar.
Fixes `spec_mode` bind not working by adding a small spectator replay delay Co-authored-by: DBmaoha <[email protected]>
Move compiler flag so that `RecalculateHighestTitanFDLevel` is MP only.
Also makes that text get localised as it was hardcoded before.
Adds a GitHub Action that auto-adds a label to a PR in case there are merge conflicts.
Translated using Weblate (Spanish (Mexico)) Currently translated at 91.3% (284 of 311 strings) Translation: Northstar/Northstar Client Localisation Translate-URL: https://translate.harmony.tf/projects/northstar/client/es_MX/ Co-authored-by: Andrés <[email protected]>
GeckoEidechse
approved these changes
Dec 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates FD branch with newest main. As such, skipping reviews entirely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No conflicts? pog